summaryrefslogtreecommitdiff
path: root/kafka/client_async.py
diff options
context:
space:
mode:
authorJeff Widman <jeff@jeffwidman.com>2017-10-18 20:28:21 -0700
committerJeff Widman <jeff@jeffwidman.com>2017-10-19 13:25:53 -0700
commit0bd5d2ab5738065df410ec2f9381844b28fe7425 (patch)
tree30760fded944a41581615e784da42b878802cd0b /kafka/client_async.py
parent13752d74ef6d4c947146899668fa41c6a317bb3f (diff)
downloadkafka-python-0bd5d2ab5738065df410ec2f9381844b28fe7425.tar.gz
Explicitly check for None rather than falsey
Be pedantic about checking for identity rather than equality to avoid issues like #1237 / 411bc08f214b7afc36f11bde2047096c06467088
Diffstat (limited to 'kafka/client_async.py')
-rw-r--r--kafka/client_async.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/kafka/client_async.py b/kafka/client_async.py
index f6fe829..aec609d 100644
--- a/kafka/client_async.py
+++ b/kafka/client_async.py
@@ -539,7 +539,7 @@ class KafkaClient(object):
task_future.success(result)
# If we got a future that is already done, don't block in _poll
- if future and future.is_done:
+ if future is not None and future.is_done:
timeout = 0
else:
idle_connection_timeout_ms = self._idle_expiry_manager.next_check_ms()
@@ -555,7 +555,7 @@ class KafkaClient(object):
# If all we had was a timeout (future is None) - only do one poll
# If we do have a future, we keep looping until it is done
- if not future or future.is_done:
+ if future is None or future.is_done:
break
return responses
@@ -660,7 +660,7 @@ class KafkaClient(object):
conn = self._conns.get(node_id)
connected = conn is not None and conn.connected()
blacked_out = conn is not None and conn.blacked_out()
- curr_inflight = len(conn.in_flight_requests) if conn else 0
+ curr_inflight = len(conn.in_flight_requests) if conn is not None else 0
if connected and curr_inflight == 0:
# if we find an established connection
# with no in-flight requests, we can stop right away