summaryrefslogtreecommitdiff
path: root/kafka/conn.py
diff options
context:
space:
mode:
authorDana Powers <dana.powers@gmail.com>2017-03-14 13:34:37 -0700
committerGitHub <noreply@github.com>2017-03-14 13:34:37 -0700
commit65ba8822b10e6f8a3ba4e9a6b0a1e6f9b785c18e (patch)
treec5b7144b04c9238ae459d80339f27b6af33b5a5c /kafka/conn.py
parenta00f9ead161e8b05ac953b460950e42fa0e0b7d6 (diff)
downloadkafka-python-65ba8822b10e6f8a3ba4e9a6b0a1e6f9b785c18e.tar.gz
Derive all api classes from Request / Response base classes (#1030)
Diffstat (limited to 'kafka/conn.py')
-rw-r--r--kafka/conn.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/kafka/conn.py b/kafka/conn.py
index 29f6911..d5b7c50 100644
--- a/kafka/conn.py
+++ b/kafka/conn.py
@@ -525,7 +525,7 @@ class BrokerConnection(object):
ifr.future.failure(error)
self.config['state_change_callback'](self)
- def send(self, request, expect_response=True):
+ def send(self, request):
"""send request, return Future()
Can block on network if request is larger than send_buffer_bytes
@@ -537,9 +537,9 @@ class BrokerConnection(object):
return future.failure(Errors.ConnectionError(str(self)))
elif not self.can_send_more():
return future.failure(Errors.TooManyInFlightRequests(str(self)))
- return self._send(request, expect_response=expect_response)
+ return self._send(request)
- def _send(self, request, expect_response=True):
+ def _send(self, request):
assert self.state in (ConnectionStates.AUTHENTICATING, ConnectionStates.CONNECTED)
future = Future()
correlation_id = self._next_correlation_id()
@@ -569,7 +569,7 @@ class BrokerConnection(object):
return future.failure(error)
log.debug('%s Request %d: %s', self, correlation_id, request)
- if expect_response:
+ if request.expect_response():
ifr = InFlightRequest(request=request,
correlation_id=correlation_id,
response_type=request.RESPONSE_TYPE,