summaryrefslogtreecommitdiff
path: root/kafka/conn.py
diff options
context:
space:
mode:
authorDana Powers <dana.powers@rd.io>2014-08-17 22:27:49 -0700
committerDana Powers <dana.powers@rd.io>2014-08-19 21:27:43 -0700
commit0a762a0bac61d83d686c062911a60cf11330d3a7 (patch)
tree275a37cf73f03adab95239c5dd1fcca14d6aad66 /kafka/conn.py
parentdac157a6fb2c2607454a276f4cd6ca0911ce6d1b (diff)
downloadkafka-python-0a762a0bac61d83d686c062911a60cf11330d3a7.tar.gz
socket.sendall should always raise an exception on error; remove extra return val check in KafkaConnection.send()
Diffstat (limited to 'kafka/conn.py')
-rw-r--r--kafka/conn.py13
1 files changed, 7 insertions, 6 deletions
diff --git a/kafka/conn.py b/kafka/conn.py
index 78fb565..ba0b996 100644
--- a/kafka/conn.py
+++ b/kafka/conn.py
@@ -106,14 +106,15 @@ class KafkaConnection(local):
def send(self, request_id, payload):
"Send a request to Kafka"
+
log.debug("About to send %d bytes to Kafka, request %d" % (len(payload), request_id))
+
+ # Make sure we have a connection
+ if self._dirty or not self._sock:
+ self.reinit()
+
try:
- if self._dirty or not self._sock:
- self.reinit()
- log.debug("Sending payload %s" % (payload,))
- sent = self._sock.sendall(payload)
- if sent is not None:
- self._raise_connection_error()
+ self._sock.sendall(payload)
except socket.error:
log.exception('Unable to send payload to Kafka')
self._raise_connection_error()