summaryrefslogtreecommitdiff
path: root/kafka/conn.py
diff options
context:
space:
mode:
authorDana Powers <dana.powers@rd.io>2016-01-03 15:43:43 -0800
committerDana Powers <dana.powers@rd.io>2016-01-03 15:43:43 -0800
commit995ea64b8fe13f9a223e67b646ac6a1430b07cb8 (patch)
treec0ab929f9d4581681eb2279f8c448c513619ac00 /kafka/conn.py
parent2b289224f9dcfa47059717a136230ca1f5b07b6d (diff)
downloadkafka-python-995ea64b8fe13f9a223e67b646ac6a1430b07cb8.tar.gz
Fix timeout bug in BrokerConnection.connect()
Diffstat (limited to 'kafka/conn.py')
-rw-r--r--kafka/conn.py17
1 files changed, 9 insertions, 8 deletions
diff --git a/kafka/conn.py b/kafka/conn.py
index 0e02382..e13913f 100644
--- a/kafka/conn.py
+++ b/kafka/conn.py
@@ -98,14 +98,15 @@ class BrokerConnection(object):
self.close() # error=TimeoutError ?
self.last_failure = time.time()
- ret = self._sock.connect_ex((self.host, self.port))
- if not ret or ret is errno.EISCONN:
- self.state = ConnectionStates.CONNECTED
- elif ret is not errno.EALREADY:
- log.error('Connect attempt to %s returned error %s.'
- ' Disconnecting.', self, ret)
- self.close()
- self.last_failure = time.time()
+ else:
+ ret = self._sock.connect_ex((self.host, self.port))
+ if not ret or ret is errno.EISCONN:
+ self.state = ConnectionStates.CONNECTED
+ elif ret is not errno.EALREADY:
+ log.error('Connect attempt to %s returned error %s.'
+ ' Disconnecting.', self, ret)
+ self.close()
+ self.last_failure = time.time()
return self.state
def blacked_out(self):