summaryrefslogtreecommitdiff
path: root/kafka/protocol
diff options
context:
space:
mode:
authorJeff Widman <jeff@jeffwidman.com>2017-02-09 12:27:16 -0800
committerDana Powers <dana.powers@gmail.com>2017-02-09 12:27:16 -0800
commit8fde79dbb5a3793b1a9ebd10e032d5f3dd535645 (patch)
treea991daae07aa142d936b37a2af7f55030355357b /kafka/protocol
parente825483d49bda41f13420311cbc9ffd59f7cee3d (diff)
downloadkafka-python-8fde79dbb5a3793b1a9ebd10e032d5f3dd535645.tar.gz
PEP-8: Spacing & removed unused imports (#899)
Diffstat (limited to 'kafka/protocol')
-rw-r--r--kafka/protocol/fetch.py2
-rw-r--r--kafka/protocol/legacy.py14
-rw-r--r--kafka/protocol/message.py7
-rw-r--r--kafka/protocol/struct.py3
4 files changed, 10 insertions, 16 deletions
diff --git a/kafka/protocol/fetch.py b/kafka/protocol/fetch.py
index 79b010f..6a9ad5b 100644
--- a/kafka/protocol/fetch.py
+++ b/kafka/protocol/fetch.py
@@ -37,7 +37,7 @@ class FetchResponse_v1(Struct):
class FetchResponse_v2(Struct):
API_KEY = 1
API_VERSION = 2
- SCHEMA = FetchResponse_v1.SCHEMA # message format changed internally
+ SCHEMA = FetchResponse_v1.SCHEMA # message format changed internally
class FetchResponse_v3(Struct):
diff --git a/kafka/protocol/legacy.py b/kafka/protocol/legacy.py
index f2ae44a..6d9329d 100644
--- a/kafka/protocol/legacy.py
+++ b/kafka/protocol/legacy.py
@@ -3,9 +3,7 @@ from __future__ import absolute_import
import logging
import struct
-from kafka.vendor import six # pylint: disable=import-error
-
-from kafka.vendor.six.moves import xrange # pylint: disable=import-error
+from kafka.vendor import six # pylint: disable=import-error
import kafka.protocol.commit
import kafka.protocol.fetch
@@ -15,13 +13,12 @@ import kafka.protocol.offset
import kafka.protocol.produce
import kafka.structs
-from kafka.codec import (
- gzip_encode, gzip_decode, snappy_encode, snappy_decode)
-from kafka.errors import ProtocolError, ChecksumError, UnsupportedCodecError
+from kafka.codec import gzip_encode, snappy_encode
+from kafka.errors import ProtocolError, UnsupportedCodecError
from kafka.structs import ConsumerMetadataResponse
from kafka.util import (
- crc32, read_short_string, read_int_string, relative_unpack,
- write_short_string, write_int_string, group_by_topic_and_partition)
+ crc32, read_short_string, relative_unpack,
+ write_int_string, group_by_topic_and_partition)
log = logging.getLogger(__name__)
@@ -320,7 +317,6 @@ class KafkaProtocol(object):
for partition, payload in six.iteritems(topic_payloads)])
for topic, topic_payloads in six.iteritems(group_by_topic_and_partition(payloads))])
-
@classmethod
def decode_offset_commit_response(cls, response):
"""
diff --git a/kafka/protocol/message.py b/kafka/protocol/message.py
index 36f03ca..bfad127 100644
--- a/kafka/protocol/message.py
+++ b/kafka/protocol/message.py
@@ -6,7 +6,6 @@ import time
from ..codec import (has_gzip, has_snappy, has_lz4,
gzip_decode, snappy_decode,
lz4_decode, lz4_decode_old_kafka)
-from . import pickle
from .struct import Struct
from .types import (
Int8, Int32, Int64, Bytes, Schema, AbstractType
@@ -36,7 +35,7 @@ class Message(Struct):
CODEC_SNAPPY = 0x02
CODEC_LZ4 = 0x03
TIMESTAMP_TYPE_MASK = 0x08
- HEADER_SIZE = 22 # crc(4), magic(1), attributes(1), timestamp(8), key+value size(4*2)
+ HEADER_SIZE = 22 # crc(4), magic(1), attributes(1), timestamp(8), key+value size(4*2)
def __init__(self, value, key=None, magic=0, attributes=0, crc=0,
timestamp=None):
@@ -127,7 +126,7 @@ class Message(Struct):
else:
raw_bytes = lz4_decode(self.value)
else:
- raise Exception('This should be impossible')
+ raise Exception('This should be impossible')
return MessageSet.decode(raw_bytes, bytes_to_read=len(raw_bytes))
@@ -145,7 +144,7 @@ class MessageSet(AbstractType):
('offset', Int64),
('message', Bytes)
)
- HEADER_SIZE = 12 # offset + message_size
+ HEADER_SIZE = 12 # offset + message_size
@classmethod
def encode(cls, items):
diff --git a/kafka/protocol/struct.py b/kafka/protocol/struct.py
index 602cfb8..a3d28d7 100644
--- a/kafka/protocol/struct.py
+++ b/kafka/protocol/struct.py
@@ -1,6 +1,5 @@
from __future__ import absolute_import
-#from collections import namedtuple
from io import BytesIO
from .abstract import AbstractType
@@ -23,7 +22,7 @@ class Struct(AbstractType):
self.encode = self._encode_self
@classmethod
- def encode(cls, item): # pylint: disable=E0202
+ def encode(cls, item): # pylint: disable=E0202
bits = []
for i, field in enumerate(cls.SCHEMA.fields):
bits.append(field.encode(item[i]))