summaryrefslogtreecommitdiff
path: root/test/test_client.py
diff options
context:
space:
mode:
authorMark Roberts <wizzat@fb.com>2014-09-03 10:56:22 -0700
committerMark Roberts <wizzat@fb.com>2014-09-03 10:56:22 -0700
commite889c8aef01e9a0b0fc55c433314041ad3dccb2a (patch)
tree20f76d942e0885b03046d90f52c5bc2be9c06c7c /test/test_client.py
parent63350070350b0b41903ab78f41b388c518f9dad7 (diff)
downloadkafka-python-e889c8aef01e9a0b0fc55c433314041ad3dccb2a.tar.gz
Fix test errors related to mocks
Diffstat (limited to 'test/test_client.py')
-rw-r--r--test/test_client.py9
1 files changed, 6 insertions, 3 deletions
diff --git a/test/test_client.py b/test/test_client.py
index 601e454..40da7ee 100644
--- a/test/test_client.py
+++ b/test/test_client.py
@@ -4,6 +4,7 @@ import six
from mock import MagicMock, patch
from kafka import KafkaClient
+import kafka.protocol
from kafka.common import (
ProduceRequest, BrokerMetadata, PartitionMetadata,
TopicAndPartition, KafkaUnavailableError,
@@ -56,11 +57,12 @@ class TestKafkaClient(unittest.TestCase):
with patch.object(KafkaClient, '_get_conn', side_effect=mock_get_conn):
client = KafkaClient(hosts=['kafka01:9092', 'kafka02:9092'])
+ req = kafka.protocol.KafkaProtocol.encode_metadata_request(b'client', 0)
with self.assertRaises(KafkaUnavailableError):
- client._send_broker_unaware_request(1, 'fake request')
+ client._send_broker_unaware_request(1, req)
for key, conn in six.iteritems(mocked_conns):
- conn.send.assert_called_with(1, 'fake request')
+ conn.send.assert_called_with(1, req)
def test_send_broker_unaware_request(self):
'Tests that call works when at least one of the host is available'
@@ -83,7 +85,8 @@ class TestKafkaClient(unittest.TestCase):
with patch.object(KafkaClient, '_get_conn', side_effect=mock_get_conn):
client = KafkaClient(hosts='kafka01:9092,kafka02:9092')
- resp = client._send_broker_unaware_request(1, 'fake request')
+ req = kafka.protocol.KafkaProtocol.encode_metadata_request(b'client', 0)
+ resp = client._send_broker_unaware_request(1, req)
self.assertEqual('valid response', resp)
mocked_conns[('kafka02', 9092)].recv.assert_called_with(1)