diff options
| author | Dana Powers <dana.powers@rd.io> | 2014-09-10 22:58:02 -0700 |
|---|---|---|
| committer | Dana Powers <dana.powers@rd.io> | 2014-09-10 23:39:13 -0700 |
| commit | 55e377bd475617cf489607c7c53890f89f590094 (patch) | |
| tree | 582b3d92cac88d7c74e7f07268077fc492e157bb /test/test_protocol.py | |
| parent | 04dbd0e7912c43e0d5cf32b29f0250dc67937df7 (diff) | |
| download | kafka-python-55e377bd475617cf489607c7c53890f89f590094.tar.gz | |
Use b''.join([]) instead of += to speedup code
Diffstat (limited to 'test/test_protocol.py')
| -rw-r--r-- | test/test_protocol.py | 36 |
1 files changed, 18 insertions, 18 deletions
diff --git a/test/test_protocol.py b/test/test_protocol.py index a028be9..d20f591 100644 --- a/test/test_protocol.py +++ b/test/test_protocol.py @@ -453,31 +453,31 @@ class TestProtocol(unittest.TestCase): self.assertEqual(encoded, expected) def _create_encoded_metadata_response(self, brokers, topics): - encoded = struct.pack('>ii', 3, len(brokers)) + encoded = [] + encoded.append(struct.pack('>ii', 3, len(brokers))) for broker in brokers: - encoded += struct.pack('>ih%dsi' % len(broker.host), broker.nodeId, - len(broker.host), broker.host, broker.port) + encoded.append(struct.pack('>ih%dsi' % len(broker.host), + broker.nodeId, len(broker.host), + broker.host, broker.port)) - encoded += struct.pack('>i', len(topics)) + encoded.append(struct.pack('>i', len(topics))) for topic in topics: - encoded += struct.pack('>hh%dsi' % len(topic.topic), - topic.error, len(topic.topic), - topic.topic, len(topic.partitions)) + encoded.append(struct.pack('>hh%dsi' % len(topic.topic), + topic.error, len(topic.topic), + topic.topic, len(topic.partitions))) for metadata in topic.partitions: - encoded += struct.pack('>hiii', - metadata.error, - metadata.partition, - metadata.leader, - len(metadata.replicas)) + encoded.append(struct.pack('>hiii', metadata.error, + metadata.partition, metadata.leader, + len(metadata.replicas))) if len(metadata.replicas) > 0: - encoded += struct.pack('>%di' % len(metadata.replicas), - *metadata.replicas) + encoded.append(struct.pack('>%di' % len(metadata.replicas), + *metadata.replicas)) - encoded += struct.pack('>i', len(metadata.isr)) + encoded.append(struct.pack('>i', len(metadata.isr))) if len(metadata.isr) > 0: - encoded += struct.pack('>%di' % len(metadata.isr), - *metadata.isr) - return encoded + encoded.append(struct.pack('>%di' % len(metadata.isr), + *metadata.isr)) + return b''.join(encoded) def test_decode_metadata_response(self): node_brokers = [ |