diff options
author | Dana Powers <dana.powers@gmail.com> | 2016-05-22 17:14:43 -0700 |
---|---|---|
committer | Dana Powers <dana.powers@gmail.com> | 2016-05-22 17:14:43 -0700 |
commit | 77cb35078a7408ebb0eab4bfc2220cc11c10d3b2 (patch) | |
tree | 1470def24c0366292cb862239cb9952f04aedf3e /test | |
parent | 1d4251a9efa4c5466ba5095f3ba199bf082a72b5 (diff) | |
download | kafka-python-77cb35078a7408ebb0eab4bfc2220cc11c10d3b2.tar.gz |
Fix socket leaks in KafkaClient (#696)
* Cleanup wakeup socketpair on close to avoid leak in KafkaClient
* Cleanup unneeded bootstrap connection to avoid leak in KafkaClient
* Dont warn on socket disconnections caused by KafkaClient.close()
Diffstat (limited to 'test')
-rw-r--r-- | test/test_client_async.py | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/test/test_client_async.py b/test/test_client_async.py index 605ef1a..5870501 100644 --- a/test/test_client_async.py +++ b/test/test_client_async.py @@ -183,19 +183,22 @@ def test_close(mocker, conn): cli = KafkaClient() mocker.patch.object(cli, '_selector') + # bootstrap connection should have been closed + assert conn.close.call_count == 1 + # Unknown node - silent cli.close(2) # Single node close cli._maybe_connect(0) - assert not conn.close.call_count - cli.close(0) assert conn.close.call_count == 1 + cli.close(0) + assert conn.close.call_count == 2 # All node close cli._maybe_connect(1) cli.close() - assert conn.close.call_count == 3 + assert conn.close.call_count == 4 def test_is_disconnected(conn): |