summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorViktor Shlapakov <vshlapakov@gmail.com>2015-02-26 15:10:55 +0300
committerViktor Shlapakov <vshlapakov@gmail.com>2015-06-03 11:22:47 +0300
commita9324f343e97ae3ceaa2acd480764818bb2b171e (patch)
treeaa736edbdbac05d1a48633238823a1f15d555cfd /test
parent4b8288a578c0cee696ef9d0523f9cec32e8b1f05 (diff)
downloadkafka-python-a9324f343e97ae3ceaa2acd480764818bb2b171e.tar.gz
Fixed compatible issues with tests
Diffstat (limited to 'test')
-rw-r--r--test/test_producer.py23
1 files changed, 11 insertions, 12 deletions
diff --git a/test/test_producer.py b/test/test_producer.py
index eecc7a7..51a74b5 100644
--- a/test/test_producer.py
+++ b/test/test_producer.py
@@ -106,11 +106,11 @@ class TestKafkaProducerSendUpstream(unittest.TestCase):
for i in range(10):
self.queue.put((TopicAndPartition("test", i), "msg %i", "key %i"))
- flag = mp.Value('c', 'f')
+ is_first_time = mp.Value('b', True)
def send_side_effect(reqs, *args, **kwargs):
self.send_calls_count.value += 1
- if flag.value == 'f':
- flag.value = 't'
+ if is_first_time.value:
+ is_first_time.value = False
raise FailedPayloadsError(reqs)
self.client.send_produce_request.side_effect = send_side_effect
@@ -166,14 +166,13 @@ class TestKafkaProducerSendUpstream(unittest.TestCase):
# the queue should have 7 elements
# 3 batches of 1 msg each were retried all this time
self.assertEqual(self.queue.empty(), False)
- left = 0
- for i in range(10):
- try:
+ try:
+ for i in range(7):
self.queue.get(timeout=0.01)
- left += 1
- except Empty:
- break
- self.assertEqual(left, 7)
+ except Empty:
+ self.fail("Should be 7 elems in the queue")
+ self.assertEqual(self.queue.empty(), True)
- # 1s / 50ms of backoff = 20 times
- self.assertEqual(self.send_calls_count.value, 20)
+ # 1s / 50ms of backoff = 20 times max
+ self.assertTrue(self.send_calls_count.value > 10)
+ self.assertTrue(self.send_calls_count.value <= 20)