diff options
| author | Dana Powers <dana.powers@gmail.com> | 2017-10-11 17:11:31 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-10-11 17:11:31 -0700 |
| commit | cfddc6bd179e236874e00a899e9349d5c9a54400 (patch) | |
| tree | 5b3c851f0d127f53adfb1c58680f6c2e6ff2fa9f /test | |
| parent | f04435c5ed97fef0975a77a8dc7bae7c284bba63 (diff) | |
| download | kafka-python-cfddc6bd179e236874e00a899e9349d5c9a54400.tar.gz | |
KAFKA-4034: Avoid unnecessary consumer coordinator lookup (#1254)
Diffstat (limited to 'test')
| -rw-r--r-- | test/test_coordinator.py | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/test/test_coordinator.py b/test/test_coordinator.py index 4115c03..aea2662 100644 --- a/test/test_coordinator.py +++ b/test/test_coordinator.py @@ -234,7 +234,7 @@ def test_fetch_committed_offsets(mocker, coordinator): assert coordinator._client.poll.call_count == 0 # general case -- send offset fetch request, get successful future - mocker.patch.object(coordinator, 'ensure_coordinator_known') + mocker.patch.object(coordinator, 'ensure_coordinator_ready') mocker.patch.object(coordinator, '_send_offset_fetch_request', return_value=Future().success('foobar')) partitions = [TopicPartition('foobar', 0)] @@ -295,16 +295,15 @@ def offsets(): def test_commit_offsets_async(mocker, coordinator, offsets): mocker.patch.object(coordinator._client, 'poll') - mocker.patch.object(coordinator, 'ensure_coordinator_known') + mocker.patch.object(coordinator, 'coordinator_unknown', return_value=False) mocker.patch.object(coordinator, '_send_offset_commit_request', return_value=Future().success('fizzbuzz')) - ret = coordinator.commit_offsets_async(offsets) - assert isinstance(ret, Future) + coordinator.commit_offsets_async(offsets) assert coordinator._send_offset_commit_request.call_count == 1 def test_commit_offsets_sync(mocker, coordinator, offsets): - mocker.patch.object(coordinator, 'ensure_coordinator_known') + mocker.patch.object(coordinator, 'ensure_coordinator_ready') mocker.patch.object(coordinator, '_send_offset_commit_request', return_value=Future().success('fizzbuzz')) cli = coordinator._client |