From 7a350e5fcf33f49094c820ba88b9cee4aeae6e12 Mon Sep 17 00:00:00 2001 From: Dana Powers Date: Fri, 15 Jul 2016 21:26:53 -0700 Subject: Cleanup error logging (#760 / #759) - add error type to all KafkaErrors - add args to BrokerResponseError - drop description from BrokerResponseError - fix bug logging errbacks as callbacks --- kafka/errors.py | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'kafka/errors.py') diff --git a/kafka/errors.py b/kafka/errors.py index df035c4..3de6ff2 100644 --- a/kafka/errors.py +++ b/kafka/errors.py @@ -7,6 +7,12 @@ class KafkaError(RuntimeError): # whether metadata should be refreshed on error invalid_metadata = False + def __str__(self): + if not self.args: + return self.__class__.__name__ + return '{}: {}'.format(self.__class__.__name__, + super(KafkaError, self).__str__()) + class IllegalStateError(KafkaError): pass @@ -56,7 +62,11 @@ class BrokerResponseError(KafkaError): description = None def __str__(self): - return '%s - %s - %s' % (self.__class__.__name__, self.errno, self.description) + """Add errno to standard KafkaError str""" + return '[Error {}] {}: {}'.format( + self.errno, + self.__class__.__name__, + super(KafkaError, self).__str__()) # pylint: disable=bad-super-call class NoError(BrokerResponseError): -- cgit v1.2.1