From fb03c69544221a25e925b8c6af45e44ac6944b2a Mon Sep 17 00:00:00 2001 From: Dana Powers Date: Fri, 6 Feb 2015 11:57:49 -0800 Subject: make partitions arg optional in *Partitioner.partition, defaulting to self.partitions from init --- kafka/partitioner/base.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'kafka/partitioner/base.py') diff --git a/kafka/partitioner/base.py b/kafka/partitioner/base.py index 0b1bb59..857f634 100644 --- a/kafka/partitioner/base.py +++ b/kafka/partitioner/base.py @@ -12,14 +12,13 @@ class Partitioner(object): """ self.partitions = partitions - def partition(self, key, partitions): + def partition(self, key, partitions=None): """ Takes a string key and num_partitions as argument and returns a partition to be used for the message Arguments: - partitions: The list of partitions is passed in every call. This - may look like an overhead, but it will be useful - (in future) when we handle cases like rebalancing + key: the key to use for partitioning + partitions: (optional) a list of partitions. """ raise NotImplementedError('partition function has to be implemented') -- cgit v1.2.1