summaryrefslogtreecommitdiff
path: root/java/src
diff options
context:
space:
mode:
authorfrsyuki <frsyuki@users.sourceforge.jp>2010-08-19 00:54:23 +0900
committerfrsyuki <frsyuki@users.sourceforge.jp>2010-08-19 00:54:23 +0900
commit1d17836b7d2eb4e5e0f25d2466df70e137642061 (patch)
tree9a5add880a1d860b1197cfc3390782bae02ecc1a /java/src
parent193a739749687e45a71a6821e625815587c4c4bf (diff)
downloadmsgpack-python-1d17836b7d2eb4e5e0f25d2466df70e137642061.tar.gz
java: NilType::create() returns NilType's one and only instance
Diffstat (limited to 'java/src')
-rw-r--r--java/src/main/java/org/msgpack/MessagePackObject.java2
-rw-r--r--java/src/main/java/org/msgpack/object/NilType.java10
-rw-r--r--java/src/test/java/org/msgpack/TestPackUnpack.java2
3 files changed, 8 insertions, 6 deletions
diff --git a/java/src/main/java/org/msgpack/MessagePackObject.java b/java/src/main/java/org/msgpack/MessagePackObject.java
index 6181f7a..2424446 100644
--- a/java/src/main/java/org/msgpack/MessagePackObject.java
+++ b/java/src/main/java/org/msgpack/MessagePackObject.java
@@ -23,7 +23,7 @@ import java.util.Map;
import java.math.BigInteger;
public abstract class MessagePackObject implements Cloneable, MessagePackable {
- public boolean isNull() {
+ public boolean isNil() {
return false;
}
diff --git a/java/src/main/java/org/msgpack/object/NilType.java b/java/src/main/java/org/msgpack/object/NilType.java
index d0572f1..c443db1 100644
--- a/java/src/main/java/org/msgpack/object/NilType.java
+++ b/java/src/main/java/org/msgpack/object/NilType.java
@@ -21,14 +21,16 @@ import java.io.IOException;
import org.msgpack.*;
public class NilType extends MessagePackObject {
- private static NilType instance = new NilType();
+ private final static NilType INSTANCE = new NilType();
public static NilType create() {
- return instance;
+ return INSTANCE;
}
+ private NilType() { }
+
@Override
- public boolean isNull() {
+ public boolean isNil() {
return true;
}
@@ -52,7 +54,7 @@ public class NilType extends MessagePackObject {
@Override
public Object clone() {
- return new NilType();
+ return INSTANCE;
}
}
diff --git a/java/src/test/java/org/msgpack/TestPackUnpack.java b/java/src/test/java/org/msgpack/TestPackUnpack.java
index 7edd411..494c8a8 100644
--- a/java/src/test/java/org/msgpack/TestPackUnpack.java
+++ b/java/src/test/java/org/msgpack/TestPackUnpack.java
@@ -130,7 +130,7 @@ public class TestPackUnpack {
ByteArrayOutputStream out = new ByteArrayOutputStream();
new Packer(out).packNil();
MessagePackObject obj = unpackOne(out);
- assertTrue(obj.isNull());
+ assertTrue(obj.isNil());
}
@Test