Merge pull request #5785 from jaimefrio/compiler_warnings

BUG: Fixed wrong return of PyArray_Partition on failure

1 files changed, 2 insertions, 2 deletions

diff --git a/numpy/core/src/multiarray/item_selection.c b/numpy/core/src/multiarray/item_selection.c
index c59a125e0..877887109 100644
--- a/numpy/core/src/multiarray/item_selection.c
+++ b/numpy/core/src/multiarray/item_selection.c
@@ -1230,7 +1230,7 @@ PyArray_Partition(PyArrayObject *op, PyArrayObject * ktharray, int axis,
 
     if (which < 0 || which >= NPY_NSELECTS) {
         PyErr_SetString(PyExc_ValueError, "not a valid partition kind");
-        return NULL;
+        return -1;
     }
     part = get_partition_func(PyArray_TYPE(op), which);
     if (part == NULL) {
@@ -1241,7 +1241,7 @@ PyArray_Partition(PyArrayObject *op, PyArrayObject * ktharray, int axis,
         else {
             PyErr_SetString(PyExc_TypeError,
                             "type does not have compare function");
-            return NULL;
+            return -1;
         }
     }