summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Wieser <wieser.eric@gmail.com>2017-07-01 23:25:37 +0100
committerEric Wieser <wieser.eric@gmail.com>2017-10-17 19:46:41 -0700
commitf9b99715be1844ce4c612dc66275f1bc662a0af8 (patch)
treed4718a4c22ebdabe5f0ad73102025e275a62da96
parent8ed314e4f1316b6b88c0c197bc6b0eb4e3f332d5 (diff)
downloadnumpy-f9b99715be1844ce4c612dc66275f1bc662a0af8.tar.gz
MAINT: improve wording of error messages
-rw-r--r--numpy/core/src/multiarray/compiled_base.c4
-rw-r--r--numpy/lib/tests/test_function_base.py4
2 files changed, 4 insertions, 4 deletions
diff --git a/numpy/core/src/multiarray/compiled_base.c b/numpy/core/src/multiarray/compiled_base.c
index f18ce155e..b0225985c 100644
--- a/numpy/core/src/multiarray/compiled_base.c
+++ b/numpy/core/src/multiarray/compiled_base.c
@@ -135,7 +135,7 @@ arr_bincount(PyObject *NPY_UNUSED(self), PyObject *args, PyObject *kwds)
if (minlength < 0) {
PyErr_SetString(PyExc_ValueError,
- "minlength must be non-negative");
+ "'minlength' must not be negative");
goto fail;
}
@@ -153,7 +153,7 @@ arr_bincount(PyObject *NPY_UNUSED(self), PyObject *args, PyObject *kwds)
minmax(numbers, len, &mn, &mx);
if (mn < 0) {
PyErr_SetString(PyExc_ValueError,
- "The first argument of bincount must be non-negative");
+ "'list' argument must have no negative elements");
goto fail;
}
ans_size = mx + 1;
diff --git a/numpy/lib/tests/test_function_base.py b/numpy/lib/tests/test_function_base.py
index 10440d97c..39edc18b4 100644
--- a/numpy/lib/tests/test_function_base.py
+++ b/numpy/lib/tests/test_function_base.py
@@ -2623,7 +2623,7 @@ class TestBincount(object):
"'str' object cannot be interpreted",
lambda: np.bincount(x, minlength="foobar"))
assert_raises_regex(ValueError,
- "must be non-negative",
+ "must not be negative",
lambda: np.bincount(x, minlength=-1))
x = np.arange(5)
@@ -2631,7 +2631,7 @@ class TestBincount(object):
"'str' object cannot be interpreted",
lambda: np.bincount(x, minlength="foobar"))
assert_raises_regex(ValueError,
- "minlength must be non-negative",
+ "must not be negative",
lambda: np.bincount(x, minlength=-1))
@dec.skipif(not HAS_REFCOUNT, "python has no sys.getrefcount")