diff options
| author | Sayed Adel <seiko@imavr.com> | 2020-11-09 03:32:54 +0200 |
|---|---|---|
| committer | Sayed Adel <seiko@imavr.com> | 2020-11-09 03:34:54 +0200 |
| commit | 11728e8a3cf967455aacc36e2d2237745b07c1e7 (patch) | |
| tree | 478848b9ba8d1b50789126874590ffb67c909e38 /benchmarks | |
| parent | 5f071c67660dd3eedd6eddb39681cd2943166e68 (diff) | |
| download | numpy-11728e8a3cf967455aacc36e2d2237745b07c1e7.tar.gz | |
BUG, Benchmark: fix passing optimization build options to asv
Diffstat (limited to 'benchmarks')
| -rw-r--r-- | benchmarks/asv_compare.conf.json.tpl | 4 | ||||
| -rw-r--r-- | benchmarks/asv_pip_nopep517.py | 15 |
2 files changed, 18 insertions, 1 deletions
diff --git a/benchmarks/asv_compare.conf.json.tpl b/benchmarks/asv_compare.conf.json.tpl index 1f339077c..03d13d985 100644 --- a/benchmarks/asv_compare.conf.json.tpl +++ b/benchmarks/asv_compare.conf.json.tpl @@ -78,7 +78,9 @@ "build_command" : [ "python setup.py build {numpy_build_options}", - "PIP_NO_BUILD_ISOLATION=false python -mpip wheel --no-deps --no-index -w {build_cache_dir} {build_dir}" + // pip ignores '--global-option' when pep517 is enabled, we also enabling pip verbose to + // be reached from asv `--verbose` so we can verify the build options. + "PIP_NO_BUILD_ISOLATION=false python {build_dir}/benchmarks/asv_pip_nopep517.py -v {numpy_global_options} --no-deps --no-index -w {build_cache_dir} {build_dir}" ], // The commits after which the regression search in `asv publish` // should start looking for regressions. Dictionary whose keys are diff --git a/benchmarks/asv_pip_nopep517.py b/benchmarks/asv_pip_nopep517.py new file mode 100644 index 000000000..9ba165493 --- /dev/null +++ b/benchmarks/asv_pip_nopep517.py @@ -0,0 +1,15 @@ +""" +This file is used by asv_compare.conf.json.tpl. +""" +import subprocess, sys +# pip ignores '--global-option' when pep517 is enabled therefore we disable it. +cmd = [sys.executable, '-mpip', 'wheel', '--no-use-pep517'] +try: + output = subprocess.check_output(cmd, stderr=subprocess.STDOUT, universal_newlines=True) +except Exception as e: + output = str(e.output) +if "no such option" in output: + print("old version of pip, escape '--no-use-pep517'") + cmd.pop() + +subprocess.run(cmd + sys.argv[1:]) |