diff options
| author | Matti Picus <matti.picus@gmail.com> | 2020-01-22 08:07:53 +1100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-22 08:07:53 +1100 |
| commit | b781887a087adfa5df7205b4808dc2052fa52875 (patch) | |
| tree | 771f50341dae47869962d3eea9fd970ae4cba605 /doc | |
| parent | 304004102e2b68de37c7cbc33a5218579418ab66 (diff) | |
| parent | 837f9f548c6798d5b5c62310deca4275a8151464 (diff) | |
| download | numpy-b781887a087adfa5df7205b4808dc2052fa52875.tar.gz | |
Merge pull request #15323 from mattip/nep-0034-2
NEP: document reimplementation of NEP 34
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/neps/nep-0034.rst | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/doc/neps/nep-0034.rst b/doc/neps/nep-0034.rst index 4863bad86..2e0ae46f4 100644 --- a/doc/neps/nep-0034.rst +++ b/doc/neps/nep-0034.rst @@ -81,7 +81,11 @@ Implementation -------------- The code to be changed is inside ``PyArray_GetArrayParamsFromObject`` and the -internal ``discover_dimentions`` function. See `PR 14794`_. +internal ``discover_dimensions`` function. The first implementation in `PR +14794`_ caused a number of downstream library failures and was reverted before +the release of 1.18. Subsequently downstream libraries fixed the places they +were using ragged arrays. The reimplementation became `PR 15119`_ which was +merged for the 1.19 release. Backward compatibility ---------------------- @@ -127,6 +131,7 @@ References and Footnotes .. _`issue 5303`: https://github.com/numpy/numpy/issues/5303 .. _sequences: https://docs.python.org/3.7/glossary.html#term-sequence .. _`PR 14794`: https://github.com/numpy/numpy/pull/14794 +.. _`PR 15119`: https://github.com/numpy/numpy/pull/15119 .. _`another library`: https://github.com/scikit-hep/awkward-array .. [0] ``np.ndarrays`` are not recursed into, rather their shape is used |