diff options
| author | Eric Wieser <wieser.eric@gmail.com> | 2019-04-14 15:49:15 -0700 |
|---|---|---|
| committer | Eric Wieser <wieser.eric@gmail.com> | 2019-05-01 08:55:34 -0700 |
| commit | e6a7e05753f8a5f56de9653bfecd85a22f53d7c6 (patch) | |
| tree | 818f4d1771b3081ab59c49b67651233bdc5ad0bf /numpy/lib/tests/test_recfunctions.py | |
| parent | b5895be146cdc3063ffa9ca8ae27b5bcf7992719 (diff) | |
| download | numpy-e6a7e05753f8a5f56de9653bfecd85a22f53d7c6.tar.gz | |
BUG: Always return views from structured_to_unstructured when possible
Also applies to unstructured_to_structured
While producing correct resutls, the test added in this commit would previously make an unecessary copy, causing the assertion to fail.
The cause was `astype` was being asked to convert from a subarray of shape `(x, y)` to one of `(x*y,)`, which it cannot do without making a copy.
This changes the approach used to skip the step of flattening subarrays to 1d
Diffstat (limited to 'numpy/lib/tests/test_recfunctions.py')
| -rw-r--r-- | numpy/lib/tests/test_recfunctions.py | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/numpy/lib/tests/test_recfunctions.py b/numpy/lib/tests/test_recfunctions.py index d1fcf2153..d4d317d30 100644 --- a/numpy/lib/tests/test_recfunctions.py +++ b/numpy/lib/tests/test_recfunctions.py @@ -243,6 +243,15 @@ class TestRecFunctions(object): assert_(dd.base is d) assert_(ddd.base is d) + # including uniform fields with subarrays unpacked + d = np.array([(1, [2, 3], [[ 4, 5], [ 6, 7]]), + (8, [9, 10], [[11, 12], [13, 14]])], + dtype=[('x0', 'i4'), ('x1', ('i4', 2)), ('x2', ('i4', (2, 2)))]) + dd = structured_to_unstructured(d) + ddd = unstructured_to_structured(dd, d.dtype) + assert_(dd.base is d) + assert_(ddd.base is d) + # test that nested fields with identical names don't break anything point = np.dtype([('x', int), ('y', int)]) triangle = np.dtype([('a', point), ('b', point), ('c', point)]) |