CHG: Change the default domain for the fit class method of the

Chebyshev and Polynomial classes to None. Add 'default' as a possible
value of the domain argument to specify the default domain. This change
fits better with my experience with this method. I feel it is safe to
make this change at this late date because the functions seem little
used as yet and I would like to get them 'right' before folks catch on
to their presence.

2 files changed, 12 insertions, 0 deletions

diff --git a/numpy/polynomial/tests/test_chebyshev.py b/numpy/polynomial/tests/test_chebyshev.py
index 13776aa87..2278ca871 100644
--- a/numpy/polynomial/tests/test_chebyshev.py
+++ b/numpy/polynomial/tests/test_chebyshev.py
@@ -463,7 +463,13 @@ class TestChebyshevClass(TestCase) :
             return x*(x - 1)*(x - 2)
         x = np.linspace(0,3)
         y = f(x)
+
+        # test default value of domain
         p = ch.Chebyshev.fit(x, y, 3)
+        assert_almost_equal(p.domain, [0,3])
+
+        # test that fit works in given domains
+        p = ch.Chebyshev.fit(x, y, 3, 'default')
         assert_almost_equal(p(x), y)
         p = ch.Chebyshev.fit(x, y, 3, None)
         assert_almost_equal(p(x), y)
diff --git a/numpy/polynomial/tests/test_polynomial.py b/numpy/polynomial/tests/test_polynomial.py
index 7ba5b6c8f..13718fe9e 100644
--- a/numpy/polynomial/tests/test_polynomial.py
+++ b/numpy/polynomial/tests/test_polynomial.py
@@ -434,7 +434,13 @@ class TestPolynomialClass(TestCase) :
             return x*(x - 1)*(x - 2)
         x = np.linspace(0,3)
         y = f(x)
+
+        # test default value of domain
         p = poly.Polynomial.fit(x, y, 3)
+        assert_almost_equal(p.domain, [0,3])
+
+        # test that fit works in given domains
+        p = poly.Polynomial.fit(x, y, 3, 'default')
         assert_almost_equal(p(x), y)
         p = poly.Polynomial.fit(x, y, 3, None)
         assert_almost_equal(p(x), y)