From eef0e0ead3107d45c940480a40f66b7077f190bb Mon Sep 17 00:00:00 2001 From: "Erik M. Bray" Date: Thu, 18 Jun 2015 18:52:16 -0400 Subject: BUG: Fixed slicing of chararrays on Python 3. When taking a slice of a chararray it was calling the rstrip() method on the resulting slice, resulting in a new array rather than a view of the original. This was an unintended consequence of the sq_slice member of the tp_as_sequence mapping being ignored in Python 3, so that slice lookups go directly through __getitem__. Fix test_expandtabs to not make the assumption that rstrip() will be applied twice to a value when using T[x][y] style indexing. --- numpy/core/defchararray.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'numpy/core/defchararray.py') diff --git a/numpy/core/defchararray.py b/numpy/core/defchararray.py index cc6cb5a38..92ea8209c 100644 --- a/numpy/core/defchararray.py +++ b/numpy/core/defchararray.py @@ -1849,12 +1849,14 @@ class chararray(ndarray): def __getitem__(self, obj): val = ndarray.__getitem__(self, obj) - if issubclass(val.dtype.type, character) and not _len(val) == 0: + + if isinstance(val, character): temp = val.rstrip() if _len(temp) == 0: val = '' else: val = temp + return val # IMPLEMENTATION NOTE: Most of the methods of this class are -- cgit v1.2.1