From 8066b45451eff24228bb5af96aad2fe0bd548383 Mon Sep 17 00:00:00 2001 From: Alex Date: Thu, 14 May 2020 18:47:59 -0700 Subject: edge first try ENH: added edge keyword argument to digitize added test --- numpy/lib/tests/test_function_base.py | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'numpy/lib/tests/test_function_base.py') diff --git a/numpy/lib/tests/test_function_base.py b/numpy/lib/tests/test_function_base.py index eb2fc3311..35225ff21 100644 --- a/numpy/lib/tests/test_function_base.py +++ b/numpy/lib/tests/test_function_base.py @@ -1712,6 +1712,9 @@ class TestDigitize: bins = [1, 1, 0] assert_array_equal(digitize(x, bins, False), [3, 2, 0, 0]) assert_array_equal(digitize(x, bins, True), [3, 3, 2, 0]) + bins = [-1, 0, 1, 2] + assert_array_equal(digitize(x, bins, False, True), [1, 2, 3, 3]) + assert_array_equal(digitize(x, bins, True, True), [1, 1, 2, 3]) bins = [1, 1, 1, 1] assert_array_equal(digitize(x, bins, False), [0, 0, 4, 4]) assert_array_equal(digitize(x, bins, True), [0, 0, 0, 4]) @@ -1740,6 +1743,7 @@ class TestDigitize: # gh-11022 x = 2**54 # loses precision in a float assert_equal(np.digitize(x, [x - 1, x + 1]), 1) + assert_raises(ValueError, digitize, x, [x - 1, x + 1], False, True) @pytest.mark.xfail( reason="gh-11022: np.core.multiarray._monoticity loses precision") -- cgit v1.2.1 From 5db1c6a48c9bf626ad171caab6085eec5b7408ea Mon Sep 17 00:00:00 2001 From: Alex Date: Fri, 15 May 2020 00:00:48 -0700 Subject: changed from large number error to different solution --- numpy/lib/tests/test_function_base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'numpy/lib/tests/test_function_base.py') diff --git a/numpy/lib/tests/test_function_base.py b/numpy/lib/tests/test_function_base.py index 35225ff21..d6e768a2b 100644 --- a/numpy/lib/tests/test_function_base.py +++ b/numpy/lib/tests/test_function_base.py @@ -1743,7 +1743,7 @@ class TestDigitize: # gh-11022 x = 2**54 # loses precision in a float assert_equal(np.digitize(x, [x - 1, x + 1]), 1) - assert_raises(ValueError, digitize, x, [x - 1, x + 1], False, True) + assert_equal(np.digitize(x, [x - 1, x + 1], False, True), 1) @pytest.mark.xfail( reason="gh-11022: np.core.multiarray._monoticity loses precision") -- cgit v1.2.1 From 5840165bd7db8628d0d5b318544943a28d799068 Mon Sep 17 00:00:00 2001 From: Alex Date: Fri, 15 May 2020 09:56:38 -0700 Subject: simplified --- numpy/lib/tests/test_function_base.py | 3 +++ 1 file changed, 3 insertions(+) (limited to 'numpy/lib/tests/test_function_base.py') diff --git a/numpy/lib/tests/test_function_base.py b/numpy/lib/tests/test_function_base.py index d6e768a2b..32f660772 100644 --- a/numpy/lib/tests/test_function_base.py +++ b/numpy/lib/tests/test_function_base.py @@ -1715,6 +1715,9 @@ class TestDigitize: bins = [-1, 0, 1, 2] assert_array_equal(digitize(x, bins, False, True), [1, 2, 3, 3]) assert_array_equal(digitize(x, bins, True, True), [1, 1, 2, 3]) + bins = [2, 1, 0, -1] + assert_array_equal(digitize(x, bins, False, True), [3, 2, 1, 1]) + assert_array_equal(digitize(x, bins, True, True), [3, 3, 2, 1]) bins = [1, 1, 1, 1] assert_array_equal(digitize(x, bins, False), [0, 0, 4, 4]) assert_array_equal(digitize(x, bins, True), [0, 0, 0, 4]) -- cgit v1.2.1