From dfc3761d6dedadb677aca907a0d098406a3241e7 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Wed, 6 Oct 2021 22:23:25 +0200 Subject: MAINT: Fix LGTM.com warning: Implicit string concatenation in a list Implicit string concatenation. Maybe missing a comma? --- numpy/f2py/rules.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'numpy') diff --git a/numpy/f2py/rules.py b/numpy/f2py/rules.py index 24777df5b..78810a0a7 100755 --- a/numpy/f2py/rules.py +++ b/numpy/f2py/rules.py @@ -566,7 +566,7 @@ rout_rules = [ 'callfortran':'#name#_return_value,#name#_return_value_len,', 'callfortranroutine':[' #name#_return_value_len = #rlength#;', ' if ((#name#_return_value = (string)malloc(' - '#name#_return_value_len+1) == NULL) {', + + '#name#_return_value_len+1) == NULL) {', ' PyErr_SetString(PyExc_MemoryError, \"out of memory\");', ' f2py_success = 0;', ' } else {', -- cgit v1.2.1 From 8add3c171446e65a22e4db961ca58273c492eb92 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Wed, 6 Oct 2021 22:55:23 +0200 Subject: MAINT: Fix LGTM.com warning: File is not always closed File may not be closed if an exception is raised. --- numpy/distutils/mingw32ccompiler.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'numpy') diff --git a/numpy/distutils/mingw32ccompiler.py b/numpy/distutils/mingw32ccompiler.py index 4681d403b..541055899 100644 --- a/numpy/distutils/mingw32ccompiler.py +++ b/numpy/distutils/mingw32ccompiler.py @@ -651,7 +651,6 @@ def generate_manifest(config): mi = int((msver - ma) * 10) # Write the manifest file manxml = msvc_manifest_xml(ma, mi) - man = open(manifest_name(config), "w") - config.temp_files.append(manifest_name(config)) - man.write(manxml) - man.close() + with open(manifest_name(config), "w") as man: + config.temp_files.append(manifest_name(config)) + man.write(manxml) -- cgit v1.2.1