From 0be72476ee0476ed992845f9ff28927be70d4752 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Fri, 15 Nov 2013 16:20:30 +0900 Subject: Always set sortkey in Change object The from_json method returns None if the key does not exist in the json data, so we don't need to check for existence of the key when constructing the object. This also ensures that the constructed object has a sortkey member. Change-Id: Ic342f8b25aeded0e999f93fa29190853354c57f0 --- pygerrit/models.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pygerrit/models.py b/pygerrit/models.py index 16a45d3..592ebbf 100644 --- a/pygerrit/models.py +++ b/pygerrit/models.py @@ -65,8 +65,7 @@ class Change(object): self.subject = from_json(json_data, "subject") self.url = from_json(json_data, "url") self.owner = Account.from_json(json_data, "owner") - if 'sortKey' in json_data: - self.sortkey = from_json(json_data, "sortKey") + self.sortkey = from_json(json_data, "sortKey") def __repr__(self): return u"" % (self.number, self.project, self.branch) -- cgit v1.2.1