From 038b5b3fd7db9d080cffb9e190d0e5a051024cdf Mon Sep 17 00:00:00 2001
From: David Pursehouse <david.pursehouse@sonymobile.com>
Date: Mon, 5 Aug 2013 19:24:35 +0900
Subject: Only allow strings as query terms and commands

Change-Id: I850978039ca10162a5ae2ab0a4f79374183107ba
---
 pygerrit/ssh.py | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

(limited to 'pygerrit/ssh.py')

diff --git a/pygerrit/ssh.py b/pygerrit/ssh.py
index adb3dd3..429ca27 100644
--- a/pygerrit/ssh.py
+++ b/pygerrit/ssh.py
@@ -140,16 +140,15 @@ class GerritSSHClient(SSHClient):
 
         Run `command` and return a `GerritSSHCommandResult`.
 
+        Raise `ValueError` if `command` is not a string.
+
         """
-        gerrit_command = ["gerrit"]
-        if isinstance(command, list):
-            gerrit_command += command
-        else:
-            gerrit_command.append(command)
+        if not isinstance(command, basestring):
+            raise ValueError("command must be a string")
+        gerrit_command = "gerrit " + command
 
         try:
-            c = " ".join(gerrit_command)
-            stdin, stdout, stderr = self.exec_command(c)
+            stdin, stdout, stderr = self.exec_command(gerrit_command)
         except SSHException as err:
             raise GerritError("Command execution error: %s" % err)
         return GerritSSHCommandResult(command, stdin, stdout, stderr)
-- 
cgit v1.2.1