From ce372a4808dfaad89cad6f74d7c618ae2c5a2111 Mon Sep 17 00:00:00 2001
From: David Pursehouse <david.pursehouse@sonymobile.com>
Date: Tue, 4 Sep 2012 11:28:43 +0900
Subject: Handle invalid port in ssh config

Raise an exception if the ssh config specifies an invalid ssh
port number.

Change-Id: I64fae04c91838a0f9c478ac9de19973e1499ed7e
---
 pygerrit/ssh.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

(limited to 'pygerrit')

diff --git a/pygerrit/ssh.py b/pygerrit/ssh.py
index 35de375..f6310a0 100644
--- a/pygerrit/ssh.py
+++ b/pygerrit/ssh.py
@@ -34,8 +34,12 @@ class GerritSSHClient(SSHClient):
             if not isfile(key_filename):
                 raise GerritError("Identity file '%s' does not exist" %
                                   key_filename)
+        try:
+            port = int(data['port'])
+        except ValueError:
+            raise GerritError("Invalid port: %s" % data['port'])
         self.connect(hostname=data['hostname'],
-                     port=int(data['port']),
+                     port=port,
                      username=data['user'],
                      key_filename=key_filename)
 
-- 
cgit v1.2.1