summaryrefslogtreecommitdiff
path: root/checkers/strings.py
diff options
context:
space:
mode:
authorBrett Cannon <brett@python.org>2014-08-29 14:24:30 -0400
committerBrett Cannon <brett@python.org>2014-08-29 14:24:30 -0400
commit91dfa1ca00a40fd6063bd4736f3e1de5843adfa6 (patch)
treeb04d0479619a33421a1f8d55f8d8a4ea394c6bdd /checkers/strings.py
parent29445fb9c72847be677b819475bfb7a3a950cbee (diff)
downloadpylint-git-91dfa1ca00a40fd6063bd4736f3e1de5843adfa6.tar.gz
Change basestring to six.string_types
--HG-- branch : python_6
Diffstat (limited to 'checkers/strings.py')
-rw-r--r--checkers/strings.py9
1 files changed, 6 insertions, 3 deletions
diff --git a/checkers/strings.py b/checkers/strings.py
index f517c4c44..03c557aaa 100644
--- a/checkers/strings.py
+++ b/checkers/strings.py
@@ -30,6 +30,9 @@ from pylint.checkers import BaseChecker, BaseTokenChecker
from pylint.checkers import utils
from pylint.checkers.utils import check_messages
+import six
+
+
_PY3K = sys.version_info[:2] >= (3, 0)
_PY27 = sys.version_info[:2] == (2, 7)
@@ -231,7 +234,7 @@ class StringFormatChecker(BaseChecker):
args = node.right
if not (isinstance(left, astroid.Const)
- and isinstance(left.value, basestring)):
+ and isinstance(left.value, six.string_types)):
return
format_string = left.value
try:
@@ -260,7 +263,7 @@ class StringFormatChecker(BaseChecker):
for k, _ in args.items:
if isinstance(k, astroid.Const):
key = k.value
- if isinstance(key, basestring):
+ if isinstance(key, six.string_types):
keys.add(key)
else:
self.add_message('bad-format-string-key',
@@ -365,7 +368,7 @@ class StringMethodsChecker(BaseChecker):
return
named_fields = set(field[0] for field in fields
- if isinstance(field[0], basestring))
+ if isinstance(field[0], six.string_types))
if num_args and manual_pos:
self.add_message('format-combined-specification',
node=node)