diff options
| author | Pierre Sassoulas <pierre.sassoulas@gmail.com> | 2019-08-10 19:00:47 +0200 |
|---|---|---|
| committer | Claudiu Popa <pcmanticore@gmail.com> | 2019-09-10 11:14:38 +0200 |
| commit | ac30e1e766903b43efdc6bf3c4ddbd0b41a7f550 (patch) | |
| tree | 7ff358d90f13e08feee6bf61623a6b0c6c5a3c5c /pylint/message | |
| parent | 572ed87ee9eb3653f7509347d82e64f278a9ec06 (diff) | |
| download | pylint-git-ac30e1e766903b43efdc6bf3c4ddbd0b41a7f550.tar.gz | |
[pylint.message] Remove a check that never fail
It seems to make performance 2/3 % better during test and during pylint
own analysis.
Diffstat (limited to 'pylint/message')
| -rw-r--r-- | pylint/message/message_definition_store.py | 4 | ||||
| -rw-r--r-- | pylint/message/message_handler_mix_in.py | 4 | ||||
| -rw-r--r-- | pylint/message/message_id_store.py | 4 |
3 files changed, 1 insertions, 11 deletions
diff --git a/pylint/message/message_definition_store.py b/pylint/message/message_definition_store.py index 1439b032c..ef0d8e2ee 100644 --- a/pylint/message/message_definition_store.py +++ b/pylint/message/message_definition_store.py @@ -49,10 +49,6 @@ class MessageDefinitionStore: self._messages_definitions[message.msgid] = message self._msgs_by_category[message.msgid[0]].append(message.msgid) - @property - def msgids(self): - return self.message_id_store.msgids - def get_message_definitions(self, msgid_or_symbol: str) -> list: """Returns the Message object for this message. :param str msgid_or_symbol: msgid_or_symbol may be either a numeric or symbolic id. diff --git a/pylint/message/message_handler_mix_in.py b/pylint/message/message_handler_mix_in.py index 5a7482951..ad2bda045 100644 --- a/pylint/message/message_handler_mix_in.py +++ b/pylint/message/message_handler_mix_in.py @@ -106,10 +106,8 @@ class MessagesHandlerMixIn: # msgid is a checker name? if msgid.lower() in self._checkers: for checker in self._checkers[msgid.lower()]: - msgids = self.msgs_store.msgids for _msgid in checker.msgs: - if _msgid in msgids: - self._set_msg_status(_msgid, enable, scope, line) + self._set_msg_status(_msgid, enable, scope, line) return # msgid is report id? diff --git a/pylint/message/message_id_store.py b/pylint/message/message_id_store.py index 2cf970aec..756888a4b 100644 --- a/pylint/message/message_id_store.py +++ b/pylint/message/message_id_store.py @@ -33,10 +33,6 @@ class MessageIdStore: def get_msgid(self, symbol: str) -> str: return self.__symbol_to_msgid[symbol] - @property - def msgids(self): - return list(self.__msgid_to_symbol.keys()) + list(self.__old_names.keys()) - def register_message_definition(self, message_definition): self.check_msgid_and_symbol(message_definition.msgid, message_definition.symbol) self.add_msgid_and_symbol(message_definition.msgid, message_definition.symbol) |