summaryrefslogtreecommitdiff
path: root/cpp/src/qpid/cluster/Cpg.cpp
diff options
context:
space:
mode:
authorAlan Conway <aconway@apache.org>2008-12-02 21:43:24 +0000
committerAlan Conway <aconway@apache.org>2008-12-02 21:43:24 +0000
commit081d94d64fa41df6f9661ad31afca0ad71fe9d12 (patch)
tree6a4fe30676916a45a8ab2f24a62f768c0e4162c4 /cpp/src/qpid/cluster/Cpg.cpp
parent7cdb9a9ab688988e596d9fce116a0998decd0972 (diff)
downloadqpid-python-081d94d64fa41df6f9661ad31afca0ad71fe9d12.tar.gz
PollableQueue: fix unsafe use of deque
git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@722622 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'cpp/src/qpid/cluster/Cpg.cpp')
-rw-r--r--cpp/src/qpid/cluster/Cpg.cpp9
1 files changed, 2 insertions, 7 deletions
diff --git a/cpp/src/qpid/cluster/Cpg.cpp b/cpp/src/qpid/cluster/Cpg.cpp
index 6a9c97139a..0d7b15cfa8 100644
--- a/cpp/src/qpid/cluster/Cpg.cpp
+++ b/cpp/src/qpid/cluster/Cpg.cpp
@@ -103,11 +103,6 @@ bool Cpg::isFlowControlEnabled() {
}
bool Cpg::mcast(const iovec* iov, int iovLen) {
- // Thread-safety note : the cpg_ calls are thread safe, but there
- // is a race below between calling cpg_flow_control_state_get()
- // and calling mcast_joined() where N threads could see the state
- // as disabled and call mcast, but only M < N messages can be sent
- // without exceeding flow control limits.
if (isFlowControlEnabled()) {
QPID_LOG(warning, "CPG flow control enabled")
return false;
@@ -135,13 +130,13 @@ void Cpg::dispatch(cpg_dispatch_t type) {
string Cpg::errorStr(cpg_error_t err, const std::string& msg) {
switch (err) {
case CPG_OK: return msg+": ok";
- case CPG_ERR_LIBRARY: return msg+": library";
+ case CPG_ERR_LIBRARY: return msg+": library error";
case CPG_ERR_TIMEOUT: return msg+": timeout";
case CPG_ERR_TRY_AGAIN: return msg+": timeout. The aisexec daemon may not be running";
case CPG_ERR_INVALID_PARAM: return msg+": invalid param";
case CPG_ERR_NO_MEMORY: return msg+": no memory";
case CPG_ERR_BAD_HANDLE: return msg+": bad handle";
- case CPG_ERR_ACCESS: return msg+": access denied. You may need to set your group ID to 'ais'";
+ case CPG_ERR_ACCESS: return msg+": access denied.";
case CPG_ERR_NOT_EXIST: return msg+": not exist";
case CPG_ERR_EXIST: return msg+": exist";
case CPG_ERR_NOT_SUPPORTED: return msg+": not supported";