Make check now starts a broker on a dynamically assigned port, so

	multiple qpid builds on one host will not conflict.

	* src/tests/run_test, start_broker, kill_broker:
	  Broker writes port to file, run_test sets QPID_PORT
	  in environment of all tests.

	* src/tests/topic_publisher.cpp, topic_listener.cpp, client_test.cpp:
	  All test clients use TestOptions to parse options from args and env.

	* src/qpid/Options.h: Renamed from CommonOptions.h
	  Simplified use of Options class.
	
	* src/qpid/Url.h: Renamed defaultPort constant.

	* src/tests/logging.cpp: 
	* src/tests/interop_runner.cpp: 
	* src/tests/TestOptions.h: 
	* src/qpidd.cpp: 
	* src/qpid/log/Options.cpp: 
	* src/qpid/log/Logger.cpp: 
	* src/qpid/broker/Broker.cpp:
	  Updated for changes to Options.


git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@550993 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 34 insertions, 43 deletions

diff --git a/cpp/src/tests/logging.cpp b/cpp/src/tests/logging.cpp
index ebe8f4d6e8..f5402aaad7 100644
--- a/cpp/src/tests/logging.cpp
+++ b/cpp/src/tests/logging.cpp
@@ -22,7 +22,7 @@
 #include "qpid/log/Logger.h"
 #include "qpid/log/Options.h"
 #include "qpid/memory.h"
-#include "qpid/CommonOptions.h"
+#include "qpid/Options.h"
 #include <boost/test/floating_point_comparison.hpp>
 #include <boost/format.hpp>
 #include <exception>
@@ -255,14 +255,6 @@ Statement statement(
 }
 
 
-struct TestOptions : public Options {
-    TestOptions(int argc, char** argv) {
-        qpid::po::options_description desc;
-        addTo(desc);
-        qpid::parseOptions(desc, argc, argv);
-    }
-};
-
 #define ARGC(argv) (sizeof(argv)/sizeof(char*))
 
 BOOST_AUTO_TEST_CASE(testOptionsParse) {
@@ -278,7 +270,8 @@ BOOST_AUTO_TEST_CASE(testOptionsParse) {
         "--log.thread", "true",
         "--log.function", "YES"
     };
-    TestOptions opts(ARGC(argv), argv);
+    qpid::log::Options opts;
+    opts.parse(ARGC(argv), argv);
     vector<string> expect=list_of("error+:foo")("debug:bar")("info");
     BOOST_CHECK_EQUAL(expect, opts.selectors);
     expect=list_of("x")("y");
@@ -306,7 +299,8 @@ BOOST_AUTO_TEST_CASE(testSelectorFromOptions) {
         "--log.enable", "debug:bar",
         "--log.enable", "info"
     };
-    TestOptions opts(ARGC(argv), argv);
+    qpid::log::Options opts;
+    opts.parse(ARGC(argv), argv);
     vector<string> expect=list_of("error+:foo")("debug:bar")("info");
     BOOST_CHECK_EQUAL(expect, opts.selectors);
     Selector s(opts);
@@ -319,37 +313,36 @@ BOOST_AUTO_TEST_CASE(testSelectorFromOptions) {
 
 BOOST_AUTO_TEST_CASE(testOptionsFormat) {
     Logger& l = clearLogger();
-    Options opts;
-    BOOST_CHECK_EQUAL(Logger::TIME|Logger::LEVEL, l.format(opts));
-    char* argv[]={
-        0,
-        "--log.time", "no", 
-        "--log.level", "no",
-        "--log.source", "1",
-        "--log.thread",  "1"
-    };
-    qpid::po::options_description desc;
-    opts.addTo(desc);
-    qpid::parseOptions(desc, ARGC(argv), argv);
-    BOOST_CHECK_EQUAL(
-        Logger::FILE|Logger::LINE|Logger::THREAD, l.format(opts));
-    opts = Options();           // Clear.
-    char* argv2[]={
-        0,
-        "--log.level", "no",
-        "--log.thread", "true",
-        "--log.function", "YES",
-        "--log.time", "YES"
-    };
-    qpid::po::options_description desc2;
-    opts.addTo(desc2);
-    qpid::parseOptions(desc2, ARGC(argv2), argv2);
-    BOOST_CHECK_EQUAL(
-        Logger::THREAD|Logger::FUNCTION|Logger::TIME,
-        l.format(opts));
+    {
+        Options opts;
+        BOOST_CHECK_EQUAL(Logger::TIME|Logger::LEVEL, l.format(opts));
+        char* argv[]={
+            0,
+            "--log.time", "no", 
+            "--log.level", "no",
+            "--log.source", "1",
+            "--log.thread",  "1"
+        };
+        opts.parse(ARGC(argv), argv);
+        BOOST_CHECK_EQUAL(
+            Logger::FILE|Logger::LINE|Logger::THREAD, l.format(opts));
+    }
+    {
+        Options opts;           // Clear.
+        char* argv[]={
+            0,
+            "--log.level", "no",
+            "--log.thread", "true",
+            "--log.function", "YES",
+            "--log.time", "YES"
+        };
+        opts.parse(ARGC(argv), argv);
+        BOOST_CHECK_EQUAL(
+            Logger::THREAD|Logger::FUNCTION|Logger::TIME,
+            l.format(opts));
+    }
 }
 
-
 BOOST_AUTO_TEST_CASE(testLoggerConfigure) {
     Logger& l = clearLogger();
     Options opts;
@@ -360,9 +353,7 @@ BOOST_AUTO_TEST_CASE(testLoggerConfigure) {
         "--log.output", "logging.tmp",
         "--log.enable", "critical"
     };
-    qpid::po::options_description desc;
-    opts.addTo(desc);
-    qpid::parseOptions(desc, ARGC(argv), argv);
+    opts.parse(ARGC(argv), argv);
     l.configure(opts, "test");
     QPID_LOG(critical, "foo"); int srcline=__LINE__;
     ifstream log("logging.tmp");