From cb070d9813e4232b4ec8409ca555b529ee5cee4b Mon Sep 17 00:00:00 2001 From: Alan Conway Date: Thu, 22 Nov 2007 23:55:39 +0000 Subject: Added framing::BodyHolder: - Uniform holder for all body types, replaces MethodHolder. - Uses in_place constructors to avoid avoid body copy. framing::AMQFrame: - Holds body in heap-allocated intrusive_ptr - Uses in_place constructors to avoid avoid body copy. Removed/downgraded to TODO many redundant FIXME comments. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@597513 13f79535-47bb-0310-9956-ffa450edef68 --- cpp/src/qpid/cluster/Cluster.cpp | 2 +- cpp/src/qpid/cluster/SessionManager.h | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) (limited to 'cpp/src/qpid/cluster') diff --git a/cpp/src/qpid/cluster/Cluster.cpp b/cpp/src/qpid/cluster/Cluster.cpp index 05ab876e14..3c73719ef9 100644 --- a/cpp/src/qpid/cluster/Cluster.cpp +++ b/cpp/src/qpid/cluster/Cluster.cpp @@ -88,7 +88,7 @@ void Cluster::handle(AMQFrame& frame) { } void Cluster::notify() { - AMQFrame frame(0, ClusterNotifyBody(ProtocolVersion(), url)); + AMQFrame frame(in_place(ProtocolVersion(), url)); handle(frame); } diff --git a/cpp/src/qpid/cluster/SessionManager.h b/cpp/src/qpid/cluster/SessionManager.h index 56cd1d9d28..10fe5f82d1 100644 --- a/cpp/src/qpid/cluster/SessionManager.h +++ b/cpp/src/qpid/cluster/SessionManager.h @@ -57,10 +57,6 @@ class SessionManager : public framing::HandlerUpdater, public framing::FrameHand /** ChannelUpdater: add cluster handlers to session. */ void update(framing::ChannelId, framing::FrameHandler::Chains&); - // FIXME aconway 2007-08-30: Need setUp and tearDown instead of just - // update, so we can tear down closed sesions. - // Or add FrameHandler::destroy(Session) to notify all handlers? - /** FrameHandler: map frames from the cluster to sessions. */ void handle(framing::AMQFrame&); -- cgit v1.2.1