From f739d191af76b1b22416f914212153db40abc17d Mon Sep 17 00:00:00 2001 From: Alan Conway Date: Mon, 8 Dec 2008 02:18:03 +0000 Subject: OutputControl and subclasses: added giveReadCredit() for IO level flow control. Cluster: Set read credit limit for cluster connections. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@724233 13f79535-47bb-0310-9956-ffa450edef68 --- cpp/src/qpid/sys/AsynchIOHandler.cpp | 31 ++++++++++++++++++++++++++++--- 1 file changed, 28 insertions(+), 3 deletions(-) (limited to 'cpp/src/qpid/sys/AsynchIOHandler.cpp') diff --git a/cpp/src/qpid/sys/AsynchIOHandler.cpp b/cpp/src/qpid/sys/AsynchIOHandler.cpp index fb4cb32734..83b6329889 100644 --- a/cpp/src/qpid/sys/AsynchIOHandler.cpp +++ b/cpp/src/qpid/sys/AsynchIOHandler.cpp @@ -44,7 +44,8 @@ AsynchIOHandler::AsynchIOHandler(std::string id, ConnectionCodec::Factory* f) : factory(f), codec(0), readError(false), - isClient(false) + isClient(false), + readCredit(InfiniteCredit) {} AsynchIOHandler::~AsynchIOHandler() { @@ -79,9 +80,22 @@ void AsynchIOHandler::activateOutput() { } // Input side -void AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) { - if (readError) { +void AsynchIOHandler::giveReadCredit(int32_t credit) { + // Check whether we started in the don't about credit state + if (readCredit.boolCompareAndSwap(InfiniteCredit, credit)) + return; + else if (readCredit.fetchAndAdd(credit) != 0) return; + // Lock and retest credit to make sure we don't race with decreasing credit + ScopedLock l(creditLock); + assert(readCredit.get() >= 0); + if (readCredit.get() != 0) + aio->startReading(); +} + +bool AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) { + if (readError) { + return false; } size_t decoded = 0; if (codec) { // Already initiated @@ -125,6 +139,17 @@ void AsynchIOHandler::readbuff(AsynchIO& , AsynchIO::BufferBase* buff) { // Give whole buffer back to aio subsystem aio->queueReadBuffer(buff); } + // Check here for read credit + if (readCredit.get() != InfiniteCredit) { + if (--readCredit == 0) { + // Lock and retest credit to make sure we don't race with increasing credit + ScopedLock l(creditLock); + assert(readCredit.get() >= 0); + if (readCredit.get() == 0) + return false; + } + } + return true; } void AsynchIOHandler::eof(AsynchIO&) { -- cgit v1.2.1