From 09ff9252575e076375d1e414126466459c21e6d3 Mon Sep 17 00:00:00 2001 From: Alan Conway Date: Wed, 17 Nov 2010 19:12:08 +0000 Subject: Aggregate Timer warnings. The Timer code logs a warning if a timer callback is started late or overruns the start time for the next callback. In cases where there are a lot of these warnings, the time taken to do the logging itself severly worsens the situation. This commit aggregates timer warnings and give a statistical report every 5 seconds at most. git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@1036169 13f79535-47bb-0310-9956-ffa450edef68 --- cpp/src/qpid/sys/TimerWarnings.cpp | 80 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 cpp/src/qpid/sys/TimerWarnings.cpp (limited to 'cpp/src/qpid/sys/TimerWarnings.cpp') diff --git a/cpp/src/qpid/sys/TimerWarnings.cpp b/cpp/src/qpid/sys/TimerWarnings.cpp new file mode 100644 index 0000000000..48a56eb472 --- /dev/null +++ b/cpp/src/qpid/sys/TimerWarnings.cpp @@ -0,0 +1,80 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ +#include "TimerWarnings.h" +#include "qpid/log/Statement.h" + +namespace qpid { +namespace sys { + +TimerWarnings::TimerWarnings(Duration reportInterval) : + interval(reportInterval), + nextReport(now(), reportInterval) +{} + +void TimerWarnings::late(const std::string& task, Duration delay) { + taskStats[task].lateDelay.add(delay); + log(); +} + +void TimerWarnings::overran(const std::string& task, Duration overrun, Duration time) +{ + taskStats[task].overranOverrun.add(overrun); + taskStats[task].overranTime.add(time); + log(); +} + +void TimerWarnings::lateAndOverran( + const std::string& task, Duration delay, Duration overrun, Duration time) +{ + taskStats[task].lateAndOverranDelay.add(delay); + taskStats[task].lateAndOverranOverrun.add(overrun); + taskStats[task].lateAndOverranTime.add(time); + log(); +} + +void TimerWarnings::log() { + if (!taskStats.empty() && nextReport < now()) { + for (TaskStatsMap::iterator i = taskStats.begin(); i != taskStats.end(); ++i) { + std::string task = i->first; + TaskStats& stats = i->second; + if (stats.lateDelay.count) + QPID_LOG(warning, task << " task late " + << stats.lateDelay.count << " times by " + << stats.lateDelay.average()/TIME_MSEC << "ms on average."); + if (stats.overranOverrun.count) + QPID_LOG(warning, task << " task overran " + << stats.overranOverrun.count << " times by " + << stats.overranOverrun.average()/TIME_MSEC << "ms (taking " + << stats.overranTime.average() << "ns) on average."); + + if (stats.lateAndOverranDelay.count) + QPID_LOG(warning, task << " task overran " + << stats.overranOverrun.count << " times by " + << stats.overranOverrun.average()/TIME_MSEC << "ms (taking " + << stats.overranTime.average() << "ns) on average."); + + } + nextReport = AbsTime(now(), interval); + taskStats.clear(); + } +} + +}} // namespace qpid::sys -- cgit v1.2.1