From b449826a61eaa0a754e55ca8143882216a07d7e0 Mon Sep 17 00:00:00 2001 From: Alan Conway Date: Tue, 25 Mar 2008 13:34:44 +0000 Subject: =?UTF-8?q?Fix=20compile=20errors/warnings=20with=20gcc=204.3=20?= =?UTF-8?q?=20-=20added=20missing=20#includes=20that=20were=20implicitly?= =?UTF-8?q?=20included=20via=20old=20headers.=20=20-=20add=20namespace-qua?= =?UTF-8?q?lifiers=20to=20fix=20"changes=20meaning=20of=20name"=20warnings?= =?UTF-8?q?.=20=20-=20./qpid/ptr=5Fmap.h:51:=20fixed=20"qualified=20return?= =?UTF-8?q?=20value"=20warning.=20=20-=20use=20const=20char*=20for=20"conv?= =?UTF-8?q?ersion=20from=20string=20constant=20to=20=E2=80=98char*?= =?UTF-8?q?=E2=80=99"=20warnings?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Applied patch from https://issues.apache.org/jira/browse/QPID-869 remove depenency on boost/date_time, causes warnings with gcc 4.3. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@640806 13f79535-47bb-0310-9956-ffa450edef68 --- cpp/src/qpid/sys/AggregateOutput.cpp | 3 ++- cpp/src/qpid/sys/Socket.h | 4 ++-- cpp/src/qpid/sys/epoll/EpollPoller.cpp | 2 +- cpp/src/qpid/sys/posix/Socket.cpp | 7 ++++--- 4 files changed, 9 insertions(+), 7 deletions(-) (limited to 'cpp/src/qpid/sys') diff --git a/cpp/src/qpid/sys/AggregateOutput.cpp b/cpp/src/qpid/sys/AggregateOutput.cpp index 74eea5ed08..57cc0c5a33 100644 --- a/cpp/src/qpid/sys/AggregateOutput.cpp +++ b/cpp/src/qpid/sys/AggregateOutput.cpp @@ -21,6 +21,7 @@ #include "qpid/sys/AggregateOutput.h" #include "qpid/log/Statement.h" +#include namespace qpid { namespace sys { @@ -54,7 +55,7 @@ void AggregateOutput::addOutputTask(OutputTask* t) void AggregateOutput::removeOutputTask(OutputTask* t) { - TaskList::iterator i = find(tasks.begin(), tasks.end(), t); + TaskList::iterator i = std::find(tasks.begin(), tasks.end(), t); if (i != tasks.end()) tasks.erase(i); } diff --git a/cpp/src/qpid/sys/Socket.h b/cpp/src/qpid/sys/Socket.h index 1594e89aac..0ebfc0c330 100644 --- a/cpp/src/qpid/sys/Socket.h +++ b/cpp/src/qpid/sys/Socket.h @@ -93,8 +93,8 @@ public: */ std::string getLocalAddress() const; - uint getLocalPort() const; - uint getRemotePort() const; + uint16_t getLocalPort() const; + uint16_t getRemotePort() const; /** Accept a connection from a socket that is already listening diff --git a/cpp/src/qpid/sys/epoll/EpollPoller.cpp b/cpp/src/qpid/sys/epoll/EpollPoller.cpp index 67783fc8c8..8936251f94 100644 --- a/cpp/src/qpid/sys/epoll/EpollPoller.cpp +++ b/cpp/src/qpid/sys/epoll/EpollPoller.cpp @@ -166,7 +166,7 @@ class PollerPrivate { case ::EPOLLOUT: return Poller::WRITABLE; case ::EPOLLIN | ::EPOLLOUT: return Poller::READ_WRITABLE; default: - return (events & ::EPOLLHUP | ::EPOLLERR) ? + return (events & (::EPOLLHUP | ::EPOLLERR)) ? Poller::DISCONNECTED : Poller::INVALID; } } diff --git a/cpp/src/qpid/sys/posix/Socket.cpp b/cpp/src/qpid/sys/posix/Socket.cpp index 028b45d03d..c286ebce27 100644 --- a/cpp/src/qpid/sys/posix/Socket.cpp +++ b/cpp/src/qpid/sys/posix/Socket.cpp @@ -31,6 +31,7 @@ #include #include #include +#include #include @@ -160,7 +161,7 @@ void Socket::connect(const std::string& host, int port) const struct hostent* hp = gethostbyname ( host.c_str() ); if (hp == 0) throw Exception(QPID_MSG("Cannot resolve " << host << ": " << h_errstr(h_errno))); - memcpy(&name.sin_addr.s_addr, hp->h_addr_list[0], hp->h_length); + ::memcpy(&name.sin_addr.s_addr, hp->h_addr_list[0], hp->h_length); if (::connect(socket, (struct sockaddr*)(&name), sizeof(name)) < 0) throw qpid::Exception(QPID_MSG(strError(errno) << ": " << host << ":" << port)); } @@ -260,12 +261,12 @@ std::string Socket::getLocalAddress() const return impl->getName(true, true); } -uint Socket::getLocalPort() const +uint16_t Socket::getLocalPort() const { return atoi(impl->getService(true).c_str()); } -uint Socket::getRemotePort() const +uint16_t Socket::getRemotePort() const { return atoi(impl->getService(true).c_str()); } -- cgit v1.2.1