From 66b1f5db27110f82d530846c450dc1b6965de7f1 Mon Sep 17 00:00:00 2001 From: Gordon Sim Date: Mon, 17 Sep 2007 14:08:17 +0000 Subject: Fix for race between flush and delivery. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@576448 13f79535-47bb-0310-9956-ffa450edef68 --- cpp/src/qpid/broker/Session.cpp | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'cpp/src') diff --git a/cpp/src/qpid/broker/Session.cpp b/cpp/src/qpid/broker/Session.cpp index d3f82655d0..8e8632e922 100644 --- a/cpp/src/qpid/broker/Session.cpp +++ b/cpp/src/qpid/broker/Session.cpp @@ -535,7 +535,13 @@ void Session::ConsumerImpl::addMessageCredit(uint32_t value) void Session::ConsumerImpl::flush() { + //need to prevent delivery after requestDispatch returns but + //before credit is reduced to zero; TODO: come up with better + //implementation of flush. + Mutex::ScopedLock l(lock); queue->requestDispatch(this, true); + byteCredit = 0; + msgCredit = 0; } void Session::ConsumerImpl::stop() -- cgit v1.2.1