From deeabcecf1c252cfb0cc62250b0ff1ee75300f07 Mon Sep 17 00:00:00 2001 From: "Stephen D. Huston" Date: Thu, 17 Jun 2010 21:11:24 +0000 Subject: Consistent comparison of unsigned values; clarify usage as well as removing potential bad compare. git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@955749 13f79535-47bb-0310-9956-ffa450edef68 --- cpp/src/qpid/acl/AclReader.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'cpp') diff --git a/cpp/src/qpid/acl/AclReader.cpp b/cpp/src/qpid/acl/AclReader.cpp index 9a39347399..31c69e69b5 100644 --- a/cpp/src/qpid/acl/AclReader.cpp +++ b/cpp/src/qpid/acl/AclReader.cpp @@ -356,7 +356,8 @@ bool AclReader::processGroupLine(tokList& toks, const bool cont) { addName(toks[i], citr->second); } } else { - if (toksSize < (cont ? 2 : 3)) { + const unsigned minimumSize = (cont ? 2 : 3); + if (toksSize < minimumSize) { errorStream << ACL_FORMAT_ERR_LOG_PREFIX << "Line : " << lineNumber << ", Insufficient tokens for group definition."; return false; -- cgit v1.2.1