From 89e14bc6a0af4ec55b8e124c886950b44b5206d9 Mon Sep 17 00:00:00 2001 From: Martin Ritchie Date: Fri, 21 May 2010 21:09:52 +0000 Subject: QPID-2581 : Update ConfigurationPlugin to provide a validateConfiguration() method simplifying the plugins git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@947177 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/qpid/server/configuration/QueueConfiguration.java | 6 ++++++ .../org/apache/qpid/server/configuration/ServerConfiguration.java | 6 ++++++ .../apache/qpid/server/configuration/VirtualHostConfiguration.java | 6 ++++++ .../qpid/server/configuration/plugins/ConfigurationPlugin.java | 4 ++++ 4 files changed, 22 insertions(+) (limited to 'java/broker/src/main') diff --git a/java/broker/src/main/java/org/apache/qpid/server/configuration/QueueConfiguration.java b/java/broker/src/main/java/org/apache/qpid/server/configuration/QueueConfiguration.java index ee68143a2d..adbb0059d8 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/configuration/QueueConfiguration.java +++ b/java/broker/src/main/java/org/apache/qpid/server/configuration/QueueConfiguration.java @@ -68,6 +68,12 @@ public class QueueConfiguration extends ConfigurationPlugin }; } + @Override + public void validateConfiguration() throws ConfigurationException + { + //Currently doesn't do validation + } + public VirtualHostConfiguration getVirtualHostConfiguration() { return _vHostConfig; diff --git a/java/broker/src/main/java/org/apache/qpid/server/configuration/ServerConfiguration.java b/java/broker/src/main/java/org/apache/qpid/server/configuration/ServerConfiguration.java index fe399669fd..8f9bded82a 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/configuration/ServerConfiguration.java +++ b/java/broker/src/main/java/org/apache/qpid/server/configuration/ServerConfiguration.java @@ -192,6 +192,12 @@ public class ServerConfiguration extends ConfigurationPlugin implements SignalHa return new String[]{""}; } + @Override + public void validateConfiguration() throws ConfigurationException + { + //Currently doesn't do validation + } + /* * Modified to enforce virtualhosts configuration in external file or main file, but not * both, as a fix for QPID-2360 and QPID-2361. diff --git a/java/broker/src/main/java/org/apache/qpid/server/configuration/VirtualHostConfiguration.java b/java/broker/src/main/java/org/apache/qpid/server/configuration/VirtualHostConfiguration.java index ca1f25952e..00b109f33b 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/configuration/VirtualHostConfiguration.java +++ b/java/broker/src/main/java/org/apache/qpid/server/configuration/VirtualHostConfiguration.java @@ -206,6 +206,12 @@ public class VirtualHostConfiguration extends ConfigurationPlugin } + @Override + public void validateConfiguration() throws ConfigurationException + { + //Currently doesn't do validation + } + public int getHouseKeepingThreadCount() { return getIntValue("housekeeping.poolSize", Runtime.getRuntime().availableProcessors()); diff --git a/java/broker/src/main/java/org/apache/qpid/server/configuration/plugins/ConfigurationPlugin.java b/java/broker/src/main/java/org/apache/qpid/server/configuration/plugins/ConfigurationPlugin.java index e6306b70d5..cb21f07eaf 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/configuration/plugins/ConfigurationPlugin.java +++ b/java/broker/src/main/java/org/apache/qpid/server/configuration/plugins/ConfigurationPlugin.java @@ -156,8 +156,12 @@ public abstract class ConfigurationPlugin _pluginConfiguration.put(elementHandler.getClass(), elementHandler); } } + + validateConfiguration(); } + abstract public void validateConfiguration() throws ConfigurationException; + protected boolean hasConfiguration() { return _configuration != null; -- cgit v1.2.1