From e153353681ef7b4960aba09dcbffb61a99f25f7b Mon Sep 17 00:00:00 2001 From: Martin Ritchie Date: Fri, 14 Sep 2007 22:47:52 +0000 Subject: QPID-531 : NO_ACK fix. Added a decrementReference in SubscriptionImpl after the message has been sent. This was previously done inside dequeueMessage() but when the reference counting was reworked earlier in the year it was moved out of that method.. but all the uses of dequeueMessage were not evaluated. The existing AckTest didon't detect this error as it only occurs with persistent messages which the client sends by default. The AckTest however only tests transient messages. Updated Test for NO_ACK raised JIRA QPID-602 to cover updating the rest of the AckTests (Updated log to show correct JIRA QPID-531 not QPID-573) git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/branches/M2.1@575811 13f79535-47bb-0310-9956-ffa450edef68 --- .../main/java/org/apache/qpid/server/queue/SubscriptionImpl.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'java/broker/src') diff --git a/java/broker/src/main/java/org/apache/qpid/server/queue/SubscriptionImpl.java b/java/broker/src/main/java/org/apache/qpid/server/queue/SubscriptionImpl.java index a7be9f2ad2..774f6e915c 100644 --- a/java/broker/src/main/java/org/apache/qpid/server/queue/SubscriptionImpl.java +++ b/java/broker/src/main/java/org/apache/qpid/server/queue/SubscriptionImpl.java @@ -307,7 +307,12 @@ public class SubscriptionImpl implements Subscription } protocolSession.getProtocolOutputConverter().writeDeliver(msg, channel.getChannelId(), deliveryTag, consumerTag); - + + if (!_acks) + { + msg.decrementReference(storeContext); + } + } } finally -- cgit v1.2.1