From dd3dc7065be453ab3c2ad73aed3ae79c8b162b0d Mon Sep 17 00:00:00 2001 From: "Rafael H. Schloming" Date: Thu, 5 Jun 2008 17:53:32 +0000 Subject: QPID-1116: fixed a race condition in connection/session close, session close now waits for the session to be detached before returning, this guarantees we won't have any active sessions when the connection close is attempted git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@663677 13f79535-47bb-0310-9956-ffa450edef68 --- .../main/java/org/apache/qpid/client/AMQConnectionDelegate_0_10.java | 2 +- java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java | 3 +-- java/client/src/main/java/org/apache/qpidity/nclient/Client.java | 3 ++- java/client/src/main/java/org/apache/qpidity/nclient/Session.java | 2 ++ 4 files changed, 6 insertions(+), 4 deletions(-) (limited to 'java/client/src') diff --git a/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_0_10.java b/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_0_10.java index bde60c433f..e741d4071c 100644 --- a/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_0_10.java +++ b/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_0_10.java @@ -152,7 +152,7 @@ public class AMQConnectionDelegate_0_10 implements AMQConnectionDelegate, Closed { if (_logger.isDebugEnabled()) { - _logger.debug("Received a connection close from the broker: Error code : " + errorCode.getCode()); + _logger.debug("Received a connection close from the broker: Error code : " + errorCode.getCode(), t); } if (_conn._exceptionListener != null) { diff --git a/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java b/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java index 17b7486fb7..e43072422c 100644 --- a/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java +++ b/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java @@ -210,8 +210,7 @@ public class AMQSession_0_10 extends AMQSession public void sendClose(long timeout) throws AMQException, FailoverException { getQpidSession().sync(); - getQpidSession().sessionRequestTimeout(0); - getQpidSession().sessionDetach(getQpidSession().getName()); + getQpidSession().close(); getCurrentException(); } diff --git a/java/client/src/main/java/org/apache/qpidity/nclient/Client.java b/java/client/src/main/java/org/apache/qpidity/nclient/Client.java index 5b45387be3..9fb4c541a9 100644 --- a/java/client/src/main/java/org/apache/qpidity/nclient/Client.java +++ b/java/client/src/main/java/org/apache/qpidity/nclient/Client.java @@ -21,6 +21,7 @@ package org.apache.qpidity.nclient; import java.util.List; import java.util.UUID; +import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicInteger; import java.util.concurrent.locks.Condition; import java.util.concurrent.locks.Lock; @@ -266,7 +267,7 @@ public class Client implements org.apache.qpidity.nclient.Connection closeOk.await(timeout - elapsed, TimeUnit.MILLISECONDS); elapsed = System.currentTimeMillis() - start; } - if(! closed ) + if(!closed) { throw new QpidException("Timed out when closing connection", ErrorCode.CONNECTION_ERROR, null); } diff --git a/java/client/src/main/java/org/apache/qpidity/nclient/Session.java b/java/client/src/main/java/org/apache/qpidity/nclient/Session.java index 833a26da87..c4d80e0fee 100644 --- a/java/client/src/main/java/org/apache/qpidity/nclient/Session.java +++ b/java/client/src/main/java/org/apache/qpidity/nclient/Session.java @@ -63,6 +63,8 @@ public interface Session */ public void sync(); + public void close(); + public void sessionDetach(byte[] name); public void sessionRequestTimeout(long expiry); -- cgit v1.2.1