From 1b7282b2df58f558fff9929fb2b6015f091b3b4c Mon Sep 17 00:00:00 2001 From: Arnaud Simon Date: Tue, 4 Dec 2007 09:54:28 +0000 Subject: removed useless lock git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@600860 13f79535-47bb-0310-9956-ffa450edef68 --- .../qpidity/transport/network/mina/MinaSender.java | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) (limited to 'java/common/src') diff --git a/java/common/src/main/java/org/apache/qpidity/transport/network/mina/MinaSender.java b/java/common/src/main/java/org/apache/qpidity/transport/network/mina/MinaSender.java index 6906c03cb6..75af9cfe20 100644 --- a/java/common/src/main/java/org/apache/qpidity/transport/network/mina/MinaSender.java +++ b/java/common/src/main/java/org/apache/qpidity/transport/network/mina/MinaSender.java @@ -30,15 +30,13 @@ import org.apache.qpidity.transport.Sender; /** * MinaSender - * */ public class MinaSender implements Sender { - private static final int TIMEOUT = 2*60*1000; + private static final int TIMEOUT = 2 * 60 * 1000; private final IoSession session; - private final Object lock = new Object(); private WriteFuture lastWrite = null; public MinaSender(IoSession session) @@ -48,26 +46,20 @@ public class MinaSender implements Sender public void send(java.nio.ByteBuffer buf) { - synchronized (lock) + if (session.isClosing()) { - if( session.isClosing()) - { - throw new RuntimeException("Trying to write on a closed socket"); - } - lastWrite = session.write(ByteBuffer.wrap(buf)); + throw new RuntimeException("Trying to write on a closed socket"); } + lastWrite = session.write(ByteBuffer.wrap(buf)); } public void close() { // MINA will sometimes throw away in-progress writes when you // ask it to close - synchronized (lock) + if (lastWrite != null) { - if (lastWrite != null) - { - lastWrite.join(); - } + lastWrite.join(); } CloseFuture closed = session.close(); closed.join(); -- cgit v1.2.1