From abfd652c09f7a267b175d7105ca0b9c1f618e368 Mon Sep 17 00:00:00 2001 From: Kim van der Riet Date: Mon, 22 Jan 2007 20:58:01 +0000 Subject: Added session close convinience methods to broker ProtocolSession, modified handlers that need to close a session to use new methods. Added logger to RequestManager and ResponseManager. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/branches/qpid.0-9@498797 13f79535-47bb-0310-9956-ffa450edef68 --- .../java/org/apache/qpid/framing/RequestManager.java | 16 ++++++++++++++-- .../java/org/apache/qpid/framing/ResponseManager.java | 17 ++++++++++++++--- 2 files changed, 28 insertions(+), 5 deletions(-) (limited to 'java/common/src') diff --git a/java/common/src/main/java/org/apache/qpid/framing/RequestManager.java b/java/common/src/main/java/org/apache/qpid/framing/RequestManager.java index 1bad249bc2..ca8735cb62 100644 --- a/java/common/src/main/java/org/apache/qpid/framing/RequestManager.java +++ b/java/common/src/main/java/org/apache/qpid/framing/RequestManager.java @@ -22,12 +22,16 @@ package org.apache.qpid.framing; import java.util.concurrent.ConcurrentHashMap; +import org.apache.log4j.Logger; + import org.apache.qpid.protocol.AMQMethodEvent; import org.apache.qpid.protocol.AMQMethodListener; import org.apache.qpid.protocol.AMQProtocolWriter; public class RequestManager { + private static final Logger logger = Logger.getLogger(RequestManager.class); + private int channel; private AMQProtocolWriter protocolWriter; @@ -71,7 +75,11 @@ public class RequestManager lastProcessedResponseId, requestMethodBody); requestSentMap.put(requestId, methodListener); protocolWriter.writeFrame(requestFrame); - // System.out.println((serverFlag ? "SRV" : "CLI") + " TX REQ: ch=" + channel + " Req[" + requestId + " " + lastProcessedResponseId + "]; " + requestMethodBody); + if (logger.isDebugEnabled()) + { + logger.debug((serverFlag ? "SRV" : "CLI") + " TX REQ: ch=" + channel + + " Req[" + requestId + " " + lastProcessedResponseId + "]; " + requestMethodBody); + } return requestId; } @@ -80,7 +88,11 @@ public class RequestManager { long requestIdStart = responseBody.getRequestId(); long requestIdStop = requestIdStart + responseBody.getBatchOffset(); - // System.out.println((serverFlag ? "SRV" : "CLI") + " RX RES: ch=" + channel + " " + responseBody + "; " + responseBody.getMethodPayload()); + if (logger.isDebugEnabled()) + { + logger.debug((serverFlag ? "SRV" : "CLI") + " RX RES: ch=" + channel + + " " + responseBody + "; " + responseBody.getMethodPayload()); + } for (long requestId = requestIdStart; requestId <= requestIdStop; requestId++) { AMQMethodListener methodListener = requestSentMap.get(requestId); diff --git a/java/common/src/main/java/org/apache/qpid/framing/ResponseManager.java b/java/common/src/main/java/org/apache/qpid/framing/ResponseManager.java index 90f33a08c0..8bc526900a 100644 --- a/java/common/src/main/java/org/apache/qpid/framing/ResponseManager.java +++ b/java/common/src/main/java/org/apache/qpid/framing/ResponseManager.java @@ -23,6 +23,8 @@ package org.apache.qpid.framing; import java.util.Iterator; import java.util.concurrent.ConcurrentHashMap; +import org.apache.log4j.Logger; + import org.apache.qpid.AMQException; import org.apache.qpid.protocol.AMQMethodEvent; import org.apache.qpid.protocol.AMQMethodListener; @@ -30,6 +32,8 @@ import org.apache.qpid.protocol.AMQProtocolWriter; public class ResponseManager { + private static final Logger logger = Logger.getLogger(ResponseManager.class); + private int channel; private AMQMethodListener methodListener; private AMQProtocolWriter protocolWriter; @@ -113,12 +117,15 @@ public class ResponseManager public void requestReceived(AMQRequestBody requestBody) throws Exception { long requestId = requestBody.getRequestId(); - // System.out.println((serverFlag ? "SRV" : "CLI") + " RX REQ: ch=" + channel + " " + requestBody + "; " + requestBody.getMethodPayload()); + if (logger.isDebugEnabled()) + { + logger.debug((serverFlag ? "SRV" : "CLI") + " RX REQ: ch=" + channel + + " " + requestBody + "; " + requestBody.getMethodPayload()); + } // TODO: responseMark is used in HA, but until then, ignore... long responseMark = requestBody.getResponseMark(); lastReceivedRequestId = requestId; responseMap.put(requestId, new ResponseStatus(requestId)); - // TODO: Update MethodEvent to use the RequestBody instead of MethodBody AMQMethodEvent methodEvent = new AMQMethodEvent(channel, requestBody.getMethodPayload(), requestId); methodListener.methodReceived(methodEvent); } @@ -126,7 +133,11 @@ public class ResponseManager public void sendResponse(long requestId, AMQMethodBody responseMethodBody) throws RequestResponseMappingException { - // System.out.println((serverFlag ? "SRV" : "CLI") + " TX RES: ch=" + channel + " Res[# " + requestId + "]; " + responseMethodBody); + if (logger.isDebugEnabled()) + { + logger.debug((serverFlag ? "SRV" : "CLI") + " TX RES: ch=" + channel + + " Res[# " + requestId + "]; " + responseMethodBody); + } ResponseStatus responseStatus = responseMap.get(requestId); if (responseStatus == null) throw new RequestResponseMappingException(requestId, -- cgit v1.2.1