From e9bed29d6775e0376a2192624f6b1ddcb442d3d3 Mon Sep 17 00:00:00 2001 From: Rupert Smith Date: Tue, 22 May 2007 13:45:50 +0000 Subject: Eliminated catch/rethrow where underlying cause was discarded. All causes now wrapped. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@540584 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/qpid/util/concurrent/BatchSynchQueueBase.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'java/common/src') diff --git a/java/common/src/main/java/org/apache/qpid/util/concurrent/BatchSynchQueueBase.java b/java/common/src/main/java/org/apache/qpid/util/concurrent/BatchSynchQueueBase.java index 521c341ca3..08b5745b19 100644 --- a/java/common/src/main/java/org/apache/qpid/util/concurrent/BatchSynchQueueBase.java +++ b/java/common/src/main/java/org/apache/qpid/util/concurrent/BatchSynchQueueBase.java @@ -37,11 +37,6 @@ import org.apache.log4j.Logger; *

*
CRC Card
Responsibilities Collaborations *
- * - * @todo To create zero garbage collecting implemention will need to adapt the queue element containers - * (SynchRefImpl) in such a way that one is needed per array element, they can be taken from/put back/cleared in - * the queue without actually being moved from the array and they implement a way of forming them into a - * collection (or Iterable) to pass to consumers (using a linked list scheme?). May not be worth the trouble. */ public abstract class BatchSynchQueueBase extends AbstractQueue implements BatchSynchQueue { @@ -350,7 +345,7 @@ public abstract class BatchSynchQueueBase extends AbstractQueue implements * Tries a synchronous put into the queue. If a consumer encounters an exception condition whilst processing the * data that is put, then this is returned to the caller wrapped inside a {@link SynchException}. * - * @param e The data element to put into the queue. + * @param e The data element to put into the queue. Cannot be null. * * @throws InterruptedException If the thread is interrupted whilst waiting to write to the queue or whilst waiting * on its entry in the queue being consumed. @@ -390,7 +385,7 @@ public abstract class BatchSynchQueueBase extends AbstractQueue implements * Retrieves and removes the head of this queue, waiting if no elements are present on this queue. * Any producer that has its data element taken by this call will be immediately unblocked. To keep the * producer blocked whilst taking just a single item, use the - * {@link #drainTo(java.util.Collection>, int, boolean)} + * {@link #drainTo(java.util.Collection>, int, boolean)} * method. There is no take method to do that because there is not usually any advantage in a synchronous hand * off design that consumes data one item at a time. It is normal to consume data in chunks to ammortize consumption * latencies accross many producers where possible. -- cgit v1.2.1