From f956df0dfbc602be3757d7bb4460be7dce739d66 Mon Sep 17 00:00:00 2001 From: Andrew Donald Kennedy Date: Thu, 17 Feb 2011 17:07:37 +0000 Subject: QPID-3065: Tidy up unused parts of Disassembler git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk/qpid@1071700 13f79535-47bb-0310-9956-ffa450edef68 --- .../qpid/transport/network/Disassembler.java | 30 ++++------------------ 1 file changed, 5 insertions(+), 25 deletions(-) (limited to 'java/common/src') diff --git a/java/common/src/main/java/org/apache/qpid/transport/network/Disassembler.java b/java/common/src/main/java/org/apache/qpid/transport/network/Disassembler.java index 341264c347..685034d1a9 100644 --- a/java/common/src/main/java/org/apache/qpid/transport/network/Disassembler.java +++ b/java/common/src/main/java/org/apache/qpid/transport/network/Disassembler.java @@ -40,19 +40,13 @@ import static java.lang.Math.min; import java.nio.ByteBuffer; import java.nio.ByteOrder; - /** * Disassembler - * */ - -public final class Disassembler implements Sender, - ProtocolDelegate +public final class Disassembler implements Sender, ProtocolDelegate { - private final Sender sender; private final int maxPayload; - private final ByteBuffer header; private final Object sendlock = new Object(); private final static ThreadLocal _encoder = new ThreadLocal() { @@ -66,14 +60,10 @@ public final class Disassembler implements Sender, { if (maxFrame <= HEADER_SIZE || maxFrame >= 64*1024) { - throw new IllegalArgumentException - ("maxFrame must be > HEADER_SIZE and < 64K: " + maxFrame); + throw new IllegalArgumentException("maxFrame must be > HEADER_SIZE and < 64K: " + maxFrame); } this.sender = sender; this.maxPayload = maxFrame - HEADER_SIZE; - this.header = ByteBuffer.allocate(HEADER_SIZE); - this.header.order(ByteOrder.BIG_ENDIAN); - } public void send(ProtocolEvent event) @@ -121,8 +111,7 @@ public final class Disassembler implements Sender, } } - private void fragment(byte flags, SegmentType type, ProtocolEvent event, - ByteBuffer buf) + private void fragment(byte flags, SegmentType type, ProtocolEvent event, ByteBuffer buf) { byte typeb = (byte) type.getValue(); byte track = event.getEncodedTrack() == Frame.L4 ? (byte) 1 : (byte) 0; @@ -173,14 +162,6 @@ public final class Disassembler implements Sender, method(method, SegmentType.COMMAND); } - private ByteBuffer copy(ByteBuffer src) - { - ByteBuffer buf = ByteBuffer.allocate(src.remaining()); - buf.put(src); - buf.flip(); - return buf; - } - private void method(Method method, SegmentType type) { BBEncoder enc = _encoder.get(); @@ -230,8 +211,7 @@ public final class Disassembler implements Sender, if (payload) { ByteBuffer body = method.getBody(); - fragment(body == null ? LAST_SEG : 0x0, SegmentType.HEADER, - method, headerSeg); + fragment(body == null ? LAST_SEG : 0x0, SegmentType.HEADER, method, headerSeg); if (body != null) { fragment(LAST_SEG, SegmentType.BODY, method, body); @@ -243,7 +223,7 @@ public final class Disassembler implements Sender, public void error(Void v, ProtocolError error) { - throw new IllegalArgumentException("" + error); + throw new IllegalArgumentException(String.valueOf(error)); } public void setIdleTimeout(int i) -- cgit v1.2.1