From 87cf93aba115c215cd0ca16e9f944e96d43a863b Mon Sep 17 00:00:00 2001 From: Rupert Smith Date: Tue, 2 Oct 2007 16:29:15 +0000 Subject: QPID-615, Added patched version of MINAs VM Pipe cleanup thread. Will replace once bug fix is in newer version of MINA. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/branches/M2.1@581293 13f79535-47bb-0310-9956-ffa450edef68 --- .../java/org/apache/qpid/requestreply/PingPongProducer.java | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'java/perftests/src') diff --git a/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java b/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java index d114c29756..ed77332e19 100644 --- a/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java +++ b/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java @@ -119,21 +119,11 @@ import java.util.concurrent.atomic.AtomicLong; * Provide command line invocation to loop the ping cycle on a configurable broker url. * * - * @todo Make the message listener a static for all replies to be sent to? It won't be any more of a bottle neck than having - * one per PingPongProducer, as will synchronize on message correlation id, allowing threads to process messages - * concurrently for different ids. Needs to be static so that when using a chained message listener and shared - * destinations between multiple PPPs, it gets notified about all replies, not just those that happen to be picked up - * by the PPP that it is atteched to. - * * @todo Use read/write lock in the onmessage, not for reading writing but to make use of a shared and exlcusive lock pair. * Obtain read lock on all messages, before decrementing the message count. At the end of the on message method add a * block that obtains the write lock for the very last message, releases any waiting producer. Means that the last * message waits until all other messages have been handled before releasing producers but allows messages to be * processed concurrently, unlike the current synchronized block. - * - * @todo Get rid of pauses between batches, it will impact the timing statistics, and generate meanigless timings. - * Instead make mina use a bounded blocking buffer, or other form of back pressure, to stop data being written - * faster than it can be sent. */ public class PingPongProducer implements Runnable /*, MessageListener*/, ExceptionListener { -- cgit v1.2.1