From ddbeecb8529f05732890370159d3af9f9c7e7926 Mon Sep 17 00:00:00 2001 From: Robert Greig Date: Thu, 1 Feb 2007 10:18:36 +0000 Subject: (Submitted by Rupert Smith) Added comments as a reminder of improvements to be made to the tests. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@502182 13f79535-47bb-0310-9956-ffa450edef68 --- .../src/main/java/org/apache/qpid/requestreply/PingPongProducer.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'java') diff --git a/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java b/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java index c212d3a0e7..7c5bb92a57 100644 --- a/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java +++ b/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java @@ -87,7 +87,8 @@ import uk.co.thebadgerset.junit.extensions.Throttle; * @todo Use read/write lock in the onmessage, not for reading writing but to make use of a shared and exlcusive lock * pair. Obtian read lock on all messages, before decrementing the message count. At the end of the on message * method add a block that obtains the write lock for the very last message, releases any waiting producer. Means - * that the last message waits until all other messages have been handled before releasing producers. + * that the last message waits until all other messages have been handled before releasing producers but allows + * messages to be processed concurrently, unlike the current synchronized block. * * @todo Set the timeout to be per message correlation id. Restart it every time a message is received (with matching id). * Means that timeout is measuring situations whether a particular ping stream has pasued for too long, rather than -- cgit v1.2.1