From d5039472ca66b7407c60d5cd097d1a612a8cb157 Mon Sep 17 00:00:00 2001 From: Gordon Sim Date: Thu, 18 Jan 2007 11:29:31 +0000 Subject: Locked Channel::close() due to race. git-svn-id: https://svn.apache.org/repos/asf/incubator/qpid/trunk/qpid@497404 13f79535-47bb-0310-9956-ffa450edef68 --- python/qpid/peer.py | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) (limited to 'python/qpid') diff --git a/python/qpid/peer.py b/python/qpid/peer.py index a265e45f43..ef913d6196 100644 --- a/python/qpid/peer.py +++ b/python/qpid/peer.py @@ -127,16 +127,22 @@ class Channel: self.queue = None self.closed = False self.reason = None + #lock used to synchronise calls to close + self.lock = thread.allocate_lock() def close(self, reason): - if isinstance(reason, Message): + self.lock.acquire() + try: + if isinstance(reason, Message): + self.reason = reason + if self.closed: + return + self.closed = True self.reason = reason - if self.closed: - return - self.closed = True - self.reason = reason - self.incoming.close() - self.responses.close() + self.incoming.close() + self.responses.close() + finally: + self.lock.release() def dispatch(self, frame, work): payload = frame.payload -- cgit v1.2.1