From e1d9be1b3590c79a0b2a6b6ad4cd3e6a65877401 Mon Sep 17 00:00:00 2001 From: Alan Conway Date: Wed, 22 Jun 2016 20:41:49 +0000 Subject: QPID-7306: Conditional compile mismatch in broker and common libs. Removed _IN_QPID_BROKER compile definition: Inconsistently set for libqpidcommon (compiled .cpp files) and libqpidbroker (uses .h) files - The broker has a binary incompatible notion of what is in the library. It sort-of works by accident: - shared_ptr only contains a T*, the mismatch is effectively doing reinterpret_cast - plain T* works for op->, but doesn't guarantee no concurrent deletes. - we create and destroy shared_ptr in libraries with _IN_QPID_BROKER set so we get cleanup, and no cores if we're lucky but there is limited protection from races. Was only used by management: - I think exposing non-shared ptr GetObject was a feature that never materialized, - if not we need a separate function or class for non-shared-ptr users. git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1749781 13f79535-47bb-0310-9956-ffa450edef68 --- qpid/cpp/src/tests/CMakeLists.txt | 2 -- 1 file changed, 2 deletions(-) (limited to 'qpid/cpp/src/tests') diff --git a/qpid/cpp/src/tests/CMakeLists.txt b/qpid/cpp/src/tests/CMakeLists.txt index 930d8b7fb7..d69d2874c4 100644 --- a/qpid/cpp/src/tests/CMakeLists.txt +++ b/qpid/cpp/src/tests/CMakeLists.txt @@ -214,7 +214,6 @@ add_executable (unit_test unit_test target_link_libraries (unit_test ${qpid_test_boost_libs} qpidmessaging qpidtypes qpidbroker qpidclient qpidcommon) -set_target_properties (unit_test PROPERTIES COMPILE_DEFINITIONS _IN_QPID_BROKER) endif (BUILD_TESTING_UNITTESTS) @@ -306,7 +305,6 @@ else (CMAKE_SYSTEM_NAME STREQUAL Windows) # Posix-only tests add_test(NAME ha_tests COMMAND ${PYTHON_EXECUTABLE} run_ha_tests) - add_test(NAME ipv6_tests COMMAND run_ipv6_tests) # Also pretty simple to convert add_test(NAME logging_tests COMMAND run_logging_tests) # Pretty simple to convert add_test(NAME paged_queue_tests COMMAND run_paged_queue_tests) -- cgit v1.2.1