From dcbe230a40f223d1e651cbd5d5626dee8d5c71b7 Mon Sep 17 00:00:00 2001 From: Alan Conway Date: Tue, 18 Jun 2013 21:09:19 +0000 Subject: QPID-4745: Alternative port allocation for tests, instead of 'qpidd --port=0' qpidd-p0 script binds a new port to a socket using bind(0), and then execs qpidd using the --socket-fd option to pass the socket to qpidd. It is intended to replace /path/to/qpidd --port 0 with qpidd-p0 /path/to/qpidd Most tests do not yet use qpidd-p0, they will be updated in a future commit. Changes: - Added qpidd-p0 - Fixed qpidd port printing logic: print port only if --port=0, regardless of --transport. git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1494306 13f79535-47bb-0310-9956-ffa450edef68 --- qpid/cpp/src/posix/QpiddBroker.cpp | 6 ++--- qpid/cpp/src/tests/CMakeLists.txt | 2 ++ qpid/cpp/src/tests/Makefile.am | 10 +++++++-- qpid/cpp/src/tests/qpidd-p0 | 46 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 59 insertions(+), 5 deletions(-) create mode 100755 qpid/cpp/src/tests/qpidd-p0 (limited to 'qpid/cpp') diff --git a/qpid/cpp/src/posix/QpiddBroker.cpp b/qpid/cpp/src/posix/QpiddBroker.cpp index 1968cbb588..831b2e0641 100644 --- a/qpid/cpp/src/posix/QpiddBroker.cpp +++ b/qpid/cpp/src/posix/QpiddBroker.cpp @@ -132,8 +132,8 @@ struct QpiddDaemon : public Daemon { /** Code for parent process */ void parent() { uint16_t port = wait(options->daemon.wait); - if (options->parent->broker.port == 0 || options->daemon.transport != TCP) - cout << port << endl; + if (options->parent->broker.port == 0 + ) cout << port << endl; } /** Code for forked child process */ @@ -196,7 +196,7 @@ int QpiddBroker::execute (QpiddOptions *options) { boost::intrusive_ptr brokerPtr(new Broker(options->broker)); ScopedSetBroker ssb(brokerPtr); brokerPtr->accept(); - if (options->broker.port == 0 || myOptions->daemon.transport != TCP) { + if (options->broker.port == 0) { uint16_t port = brokerPtr->getPort(myOptions->daemon.transport); cout << port << endl; if (options->broker.enableMgmt) { diff --git a/qpid/cpp/src/tests/CMakeLists.txt b/qpid/cpp/src/tests/CMakeLists.txt index 337403df25..4763bc0b80 100644 --- a/qpid/cpp/src/tests/CMakeLists.txt +++ b/qpid/cpp/src/tests/CMakeLists.txt @@ -47,6 +47,8 @@ else (CMAKE_SYSTEM_NAME STREQUAL Windows) ${CMAKE_CURRENT_BINARY_DIR}/test_env.sh) endif (CMAKE_SYSTEM_NAME STREQUAL Windows) +# Copy qpidd-p0 script to build directory so tests can find it. +configure_file (${CMAKE_CURRENT_SOURCE_DIR}/qpidd-p0 ${CMAKE_CURRENT_BINARY_DIR} COPYONLY) # If valgrind is selected in the configuration step, set up the path to it # for CTest. diff --git a/qpid/cpp/src/tests/Makefile.am b/qpid/cpp/src/tests/Makefile.am index 92532895c5..7aa8add442 100644 --- a/qpid/cpp/src/tests/Makefile.am +++ b/qpid/cpp/src/tests/Makefile.am @@ -380,13 +380,19 @@ check-long: $(MAKE) check TESTS="$(LONG_TESTS)" VALGRIND= # Things that should be built before the check target runs. -check-am: python_prep test_env.sh install_env.sh sasl_config +check-am: python_prep test_env.sh install_env.sh sasl_config qpidd-p0 PYTHON_SRC_DIR=$(abs_srcdir)/../../../python PYTHON_BLD_DIR=$(abs_builddir)/python +# Copy qpidd-p0 to build directory so tests can find it easily. +qpidd-p0: force + cp $(abs_srcdir)/qpidd-p0 . + +force: + # Generate python client as part of the all-am target so it gets built before tests. -all-am: python_prep +all-am: python_prep qpidd-p0 python_prep: if test -d $(PYTHON_SRC_DIR); \ diff --git a/qpid/cpp/src/tests/qpidd-p0 b/qpid/cpp/src/tests/qpidd-p0 new file mode 100755 index 0000000000..9bc605c0aa --- /dev/null +++ b/qpid/cpp/src/tests/qpidd-p0 @@ -0,0 +1,46 @@ +#!/usr/bin/env python + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Wrapper script to allocate a port and fork a broker to listen on it. +# +# Instead of this: +# qpidd --port 0 +# do this: +# qpidd-p0 +# +# The port is bound by python code, and then handed over to the broker via the +# --socket-fd option. This avoids problems with the qpidd --port 0 option which +# ocassional fails with an "address in use" error. It's not clear why --port 0 +# doesn't work, it may be to do with the way qpidd binds a port to multiple +# addresses on a multi-homed host. +# + +import subprocess, socket, time, os, sys + +s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) +s.bind(("", 0)) +s.listen(5) +port = s.getsockname()[1] +print port +sys.stdout.flush() +if len(sys.argv) > 1: + cmd = sys.argv[1:] + ["--socket-fd", str(s.fileno()), "--listen-disable=tcp", "--port", str(port)] + os.execvp(sys.argv[1], cmd) -- cgit v1.2.1