From 2d5bedc7a219b43eedbfe33bbe12b750c3fc4519 Mon Sep 17 00:00:00 2001 From: Alex Rudyy Date: Wed, 24 Sep 2014 11:16:23 +0000 Subject: QPID-6114: Migrate the State member variable to AbstractConfiguredObject class git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1627278 13f79535-47bb-0310-9956-ffa450edef68 --- .../plugins/ACLFileAccessControlProviderImpl.java | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) (limited to 'qpid/java/broker-plugins/access-control/src') diff --git a/qpid/java/broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/plugins/ACLFileAccessControlProviderImpl.java b/qpid/java/broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/plugins/ACLFileAccessControlProviderImpl.java index 5708e27e33..f0edc59025 100644 --- a/qpid/java/broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/plugins/ACLFileAccessControlProviderImpl.java +++ b/qpid/java/broker-plugins/access-control/src/main/java/org/apache/qpid/server/security/access/plugins/ACLFileAccessControlProviderImpl.java @@ -49,8 +49,6 @@ public class ACLFileAccessControlProviderImpl protected DefaultAccessControl _accessControl; protected final Broker _broker; - private AtomicReference _state = new AtomicReference<>(State.UNINITIALIZED); - @ManagedAttributeField private String _path; @@ -97,12 +95,6 @@ public class ACLFileAccessControlProviderImpl return _path; } - @Override - public State getState() - { - return _state.get(); - } - @Override public Collection getChildren(Class clazz) { @@ -116,18 +108,18 @@ public class ACLFileAccessControlProviderImpl if(_broker.isManagementMode()) { - _state.set(_accessControl.validate() ? State.QUIESCED : State.ERRORED); + setState(_accessControl.validate() ? State.QUIESCED : State.ERRORED); } else { try { _accessControl.open(); - _state.set(State.ACTIVE); + setState(State.ACTIVE); } catch (RuntimeException e) { - _state.set(State.ERRORED); + setState(State.ERRORED); if (_broker.isManagementMode()) { LOGGER.warn("Failed to activate ACL provider: " + getName(), e); @@ -150,14 +142,14 @@ public class ACLFileAccessControlProviderImpl @StateTransition(currentState = State.UNINITIALIZED, desiredState = State.QUIESCED) private void startQuiesced() { - _state.set(State.QUIESCED); + setState(State.QUIESCED); } @StateTransition(currentState = {State.ACTIVE, State.QUIESCED, State.ERRORED}, desiredState = State.DELETED) private void doDelete() { close(); - _state.set(State.DELETED); + setState(State.DELETED); deleted(); } -- cgit v1.2.1