From bb3fe508f98ec31109f951fb059ee49746a36d48 Mon Sep 17 00:00:00 2001 From: Robert Godfrey Date: Fri, 27 Jan 2012 20:15:31 +0000 Subject: NO-JIRA: Encapsulate fields, use private members and accesors (keep checkstyle happy) git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@1236867 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/qpid/junit/extensions/SetupTaskHandler.java | 4 ++-- .../qpid/junit/extensions/listeners/XMLTestListener.java | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'qpid/java/junit-toolkit') diff --git a/qpid/java/junit-toolkit/src/main/org/apache/qpid/junit/extensions/SetupTaskHandler.java b/qpid/java/junit-toolkit/src/main/org/apache/qpid/junit/extensions/SetupTaskHandler.java index b91ce41ad3..631f4dcdf0 100644 --- a/qpid/java/junit-toolkit/src/main/org/apache/qpid/junit/extensions/SetupTaskHandler.java +++ b/qpid/java/junit-toolkit/src/main/org/apache/qpid/junit/extensions/SetupTaskHandler.java @@ -43,10 +43,10 @@ import java.util.Queue; public class SetupTaskHandler implements SetupTaskAware { /** Holds the set up tasks. */ - Queue setups = new LinkedList(); + private Queue setups = new LinkedList(); /** Holds the tear down tasks. */ - Queue teardowns = new StackQueue(); + private Queue teardowns = new StackQueue(); /** * Adds the specified task to the tests setup. diff --git a/qpid/java/junit-toolkit/src/main/org/apache/qpid/junit/extensions/listeners/XMLTestListener.java b/qpid/java/junit-toolkit/src/main/org/apache/qpid/junit/extensions/listeners/XMLTestListener.java index ac875f89cf..003bd0cecc 100644 --- a/qpid/java/junit-toolkit/src/main/org/apache/qpid/junit/extensions/listeners/XMLTestListener.java +++ b/qpid/java/junit-toolkit/src/main/org/apache/qpid/junit/extensions/listeners/XMLTestListener.java @@ -81,25 +81,25 @@ public class XMLTestListener implements TKTestListener, ShutdownHookable * explicit thread id must be used, where notifications come from different threads than the ones that called * the test method. */ - Map threadLocalResults = Collections.synchronizedMap(new LinkedHashMap()); + private Map threadLocalResults = Collections.synchronizedMap(new LinkedHashMap()); /** * Holds results for tests that have ended. Transferring these results here from the per-thread results map, means * that the thread id is freed for the thread to generate more results. */ - List results = new ArrayList(); + private List results = new ArrayList(); /** Holds the overall error count. */ - protected int errors = 0; + private int errors = 0; /** Holds the overall failure count. */ - protected int failures = 0; + private int failures = 0; /** Holds the overall tests run count. */ - protected int runs = 0; + private int runs = 0; /** Holds the name of the class that tests are being run for. */ - String testClassName; + private String testClassName; /** * Creates a new XML results output listener that writes to the specified location. -- cgit v1.2.1