From 8c8130d0288446f88deef393823cccffcaed474d Mon Sep 17 00:00:00 2001
From: Robert Godfrey <rgodfrey@apache.org>
Date: Sun, 12 Sep 2010 22:40:40 +0000
Subject: QPID-2857 : Address issues found by running FindBugs against the Java
 codebase

git-svn-id: https://svn.apache.org/repos/asf/qpid/trunk@996393 13f79535-47bb-0310-9956-ffa450edef68
---
 .../src/main/java/org/apache/qpid/management/ui/ServerRegistry.java   | 2 +-
 .../main/java/org/apache/qpid/management/ui/views/ViewUtility.java    | 2 +-
 .../org/apache/qpid/management/ui/views/type/QueueTypeTabControl.java | 4 +---
 3 files changed, 3 insertions(+), 5 deletions(-)

(limited to 'qpid/java/management/eclipse-plugin')

diff --git a/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ServerRegistry.java b/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ServerRegistry.java
index fc17538cf9..c3c0277f7d 100644
--- a/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ServerRegistry.java
+++ b/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/ServerRegistry.java
@@ -135,7 +135,7 @@ public abstract class ServerRegistry
     
     protected void removeVirtualHostManagerMBean(ManagedBean mbean)
     {
-        _vhostManagers.remove(mbean);
+        _vhostManagers.remove(mbean.getVirtualHostName());
     }
     
     public ManagedBean getVirtualHostManagerMBean(String virtualHost)
diff --git a/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/ViewUtility.java b/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/ViewUtility.java
index 655718c098..d95ca8b2e4 100644
--- a/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/ViewUtility.java
+++ b/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/ViewUtility.java
@@ -271,7 +271,7 @@ public class ViewUtility
         List objectData = (List)compositeHolder.getData();
         if (objectData == null || objectData.isEmpty())
         {
-            //          TODO
+           //          TODO
         }
 
         // Get the index of record to be shown.
diff --git a/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/type/QueueTypeTabControl.java b/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/type/QueueTypeTabControl.java
index c5ab5184ee..285dcfc0ee 100644
--- a/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/type/QueueTypeTabControl.java
+++ b/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/type/QueueTypeTabControl.java
@@ -650,7 +650,6 @@ public class QueueTypeTabControl extends MBeanTypeTabControl
     private class QueueLabelProviderImpl extends LabelProvider implements ITableLabelProvider
     {
         @SuppressWarnings("unchecked")
-        @Override
         public String getColumnText(Object element, int columnIndex)
         {
             List<Object> attributes = (List<Object>) element;
@@ -677,8 +676,7 @@ public class QueueTypeTabControl extends MBeanTypeTabControl
                     return String.valueOf(attributes.get(columnIndex));
             }
         }
-        
-        @Override
+
         public Image getColumnImage(Object element, int columnIndex)
         {
             return null;
-- 
cgit v1.2.1